Skip to content

Multiple fixes covering logic around flags, error propagation and objects returned in report_only mode#16

Merged
copybara-service[bot] merged 1 commit intomainfrom
test_882759529
Mar 13, 2026
Merged

Multiple fixes covering logic around flags, error propagation and objects returned in report_only mode#16
copybara-service[bot] merged 1 commit intomainfrom
test_882759529

Conversation

@copybara-service
Copy link
Copy Markdown

@copybara-service copybara-service bot commented Mar 13, 2026

  • Fixed a bug in report_only mode where we returned a None object if a pickle file is identified as malicious. We return the original loaded file instead.
  • Streamlined the logic around flags to avoid duplicated code and better error propagation
  • LOAD_BUILD can have differing args due to differing pickle implementations. We were missing certain cases of BUILD instructions because of this.

@0x00nier 0x00nier self-assigned this Mar 13, 2026
@0x00nier 0x00nier changed the title - Fixed a bug in report_only mode where we returned a None object if a pickle file is identified as malicious. We return the original loaded file instead. Multiple fixes covering flag logic, error propagation and report_only mode Mar 13, 2026
@0x00nier 0x00nier changed the title Multiple fixes covering flag logic, error propagation and report_only mode Multiple fixes covering logic around flags, error propagation and objects returned in report_only mode Mar 13, 2026
PiperOrigin-RevId: 883325139
@copybara-service copybara-service bot merged commit badb529 into main Mar 13, 2026
@copybara-service copybara-service bot deleted the test_882759529 branch March 13, 2026 20:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants