Multiple fixes covering logic around flags, error propagation and objects returned in report_only mode#16
Merged
copybara-service[bot] merged 1 commit intomainfrom Mar 13, 2026
Conversation
0x00nier
approved these changes
Mar 13, 2026
report_only mode where we returned a None object if a pickle file is identified as malicious. We return the original loaded file instead.PiperOrigin-RevId: 883325139
32bafd8 to
badb529
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
report_only modewhere we returned a None object if a pickle file is identified as malicious. We return the original loaded file instead.LOAD_BUILDcan have differing args due to differing pickle implementations. We were missing certain cases of BUILD instructions because of this.