This repository was archived by the owner on Oct 31, 2025. It is now read-only.
[trax] Explicitly set jax_pmap_shmap_merge=False.#1814
Merged
copybara-service[bot] merged 1 commit intomasterfrom Sep 26, 2025
Merged
[trax] Explicitly set jax_pmap_shmap_merge=False.#1814copybara-service[bot] merged 1 commit intomasterfrom
jax_pmap_shmap_merge=False.#1814copybara-service[bot] merged 1 commit intomasterfrom
Conversation
copybara-service
bot
force-pushed
the
test_811399636
branch
from
a3b55dd to
2729ab9
Compare
copybara-service
bot
changed the title
jax_pmap_shmap_merge=True.jax_pmap_shmap_merge=False.
`trainer._multi_device_update_fn` uses `jax.pmap` and when `jax_pmap_shmap_merge=True`, `jax.pmap` requires inputs be explicitly sharded as the underlying `jax.jit` expects. This would need to be fixed if `jax_pmap_shmap_merge=True`. PiperOrigin-RevId: 811810947
copybara-service
bot
force-pushed
the
test_811399636
branch
from
2729ab9 to
31022d6
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
[trax] Explicitly set
jax_pmap_shmap_merge=False.trainer._multi_device_update_fnusesjax.pmapand whenjax_pmap_shmap_merge=True,jax.pmaprequires inputs be explicitly sharded as the underlyingjax.jitexpects.This would need to be fixed if
jax_pmap_shmap_merge=True.