serverutil: Serve metrics on dedicated mux #3845
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale
The metrics HTTP listener currently uses
http.DefaultServeMux(viahttp.Handle/http.HandleFunc).If
net/http/pprofis imported elsewhere in the binary (e.g., for debugging), its handlers areregistered on the default mux and become reachable on the metrics endpoint.
While the metrics listener defaults to localhost, deployments may expose it for scraping
(Prometheus / managed monitoring). Using a dedicated mux makes the contract explicit and prevents
unintended handler exposure.
Testing
Added
TestHTTPServerDoesNotExposeDefaultServeMuxwhich:net/http/pprof(registers on default mux).serverutil.Mainwith an HTTP endpoint./metricsreturns 200./debug/pprof/returns 404.