Skip to content

fix: no longer generate cross-package references for mixin objects - #1211

Merged
viacheslav-rostovtsev merged 4 commits into
googleapis:mainfrom
viacheslav-rostovtsev:dev/virost/fix_crosspackage_references
Aug 13, 2025
Merged

viacheslav-rostovtsev merged 4 commits into
googleapis:mainfrom
viacheslav-rostovtsev:dev/virost/fix_crosspackage_references

Conversation

@viacheslav-rostovtsev

@viacheslav-rostovtsev viacheslav-rostovtsev commented Jun 26, 2025

Copy link
Copy Markdown
Member

fixes: #824

@viacheslav-rostovtsev
viacheslav-rostovtsev requested a review from a team June 26, 2025 23:18
@viacheslav-rostovtsev
viacheslav-rostovtsev force-pushed the dev/virost/fix_crosspackage_references branch from 12d1690 to b23924d Compare August 12, 2025 17:53
dazuma
dazuma previously approved these changes Aug 12, 2025

@dazuma dazuma left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One nit, otherwise I think this works.

Comment thread gapic-generator/test/gapic/mixins/mixins_test.rb
@viacheslav-rostovtsev
viacheslav-rostovtsev force-pushed the dev/virost/fix_crosspackage_references branch from cc280e6 to c3db4c7 Compare August 13, 2025 01:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Spurious cross-reference YARD conversions happen when the target is in a gem dependency

2 participants