Skip to content
This repository was archived by the owner on Oct 8, 2025. It is now read-only.

Remove Firebase/Firestore dependency in .podspec file#78

Open
sanghyeok-kim wants to merge 1 commit into
googleapis:mainfrom
sanghyeok-kim:remove_firestore_dependency
Open

Remove Firebase/Firestore dependency in .podspec file#78
sanghyeok-kim wants to merge 1 commit into
googleapis:mainfrom
sanghyeok-kim:remove_firestore_dependency

Conversation

@sanghyeok-kim

Copy link
Copy Markdown

Context

Currently, Firebase/FireStore includes this library as a dependency in its podspec file,

s.dependency "Firebase/Firestore"

but it is not used anywhere.
And it's not just unused, it causes compile errors with objc code in existing projects.

For example, the count property in the FIRAggregateQuerySnapshot.mm code of Firebase/FireStore causes a compile error due to a conflict with the existing Objc's count.

- (NSNumber *)count {
  return (NSNumber *)[self valueForAggregateField:[FIRAggregateField aggregateFieldForCount]];
}

Error message

Multiple methods named 'count' found with mismatched result, parameter type, or attributes

Changes

Therefore, I propose removing this unnecessary dependency to avoid conflicts with existing Objc code and prevent compile errors.

@sanghyeok-kim
sanghyeok-kim requested a review from a team June 5, 2024 08:12
@sanghyeok-kim sanghyeok-kim changed the title Remove Firebase/Firestore dependency in podspec file Remove Firebase/Firestore dependency in .podspec file Jun 5, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant