This repository was archived by the owner on Oct 8, 2025. It is now read-only.
Remove Firebase/Firestore dependency in .podspec file#78
Open
sanghyeok-kim wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
Currently,
Firebase/FireStoreincludes this library as a dependency in its podspec file,but it is not used anywhere.
And it's not just unused, it causes compile errors with objc code in existing projects.
For example, the
countproperty in theFIRAggregateQuerySnapshot.mmcode ofFirebase/FireStorecauses a compile error due to a conflict with the existing Objc'scount.Error message
Changes
Therefore, I propose removing this unnecessary dependency to avoid conflicts with existing Objc code and prevent compile errors.