feat(firestore): update and delete pipeline DML stages#14331
Merged
Conversation
product-auto-label
Bot
added
the
api: firestore
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request introduces Update and Delete stages to the Firestore Pipeline, including internal stage implementations, proto mapping, and tests. The review feedback suggests refining the documentation and examples to correctly handle variadic arguments and removing unused DeleteOption types and parameters to maintain a clean API.
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
shollyman
approved these changes
Apr 2, 2026
| // | ||
| // This method updates the documents in place based on the data flowing through the pipeline. | ||
| // You can optionally specify a list of [Selectable] field transformations using [WithUpdateTransformations]. | ||
| // If no transformations are provided, it performs the update in-place without any changes. |
Contributor
There was a problem hiding this comment.
it performs the update in-place without any changes.
This seems a little unclear to me. Doesn't it replace the whole doc if no selectables are given?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Corresponding Java PR which was used as reference: googleapis/java-firestore#2317