Skip to content

fix: Package name #14629

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
joze-liburn wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: Package name #14629

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions pubsub/MIGRATING.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,17 +12,17 @@ Note: The end of support date has been extended to December 31st, 2026 from the

There are two new packages:

* [cloud.google.com/go/v2](http://cloud.google.com/go/v2): The new main v2 package.
* [cloud.google.com/go/pubsub/v2](http://cloud.google.com/go/pubsub/v2): The new main v2 package.

* [cloud.google.com/go/v2/apiv1/pubsubpb](http://cloud.google.com/go/v2/apiv1/pubsubpb): The auto-generated protobuf Go types that are used as arguments for admin operations.
* [cloud.google.com/go/pubsub/v2/apiv1/pubsubpb](http://cloud.google.com/go/pubsub/v2/apiv1/pubsubpb): The auto-generated protobuf Go types that are used as arguments for admin operations.
Comment on lines +15 to +17
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot May 22, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

security-medium medium

The links should use https instead of http for better security and to follow modern web standards. Additionally, there are trailing spaces at the end of lines 15 and 17 that should be removed.

Suggested change
* [cloud.google.com/go/pubsub/v2](http://cloud.google.com/go/pubsub/v2): The new main v2 package.
* [cloud.google.com/go/v2/apiv1/pubsubpb](http://cloud.google.com/go/v2/apiv1/pubsubpb): The auto-generated protobuf Go types that are used as arguments for admin operations.
* [cloud.google.com/go/pubsub/v2/apiv1/pubsubpb](http://cloud.google.com/go/pubsub/v2/apiv1/pubsubpb): The auto-generated protobuf Go types that are used as arguments for admin operations.
* [cloud.google.com/go/pubsub/v2](https://cloud.google.com/go/pubsub/v2): The new main v2 package.
* [cloud.google.com/go/pubsub/v2/apiv1/pubsubpb](https://cloud.google.com/go/pubsub/v2/apiv1/pubsubpb): The auto-generated protobuf Go types that are used as arguments for admin operations.


For other relevant packages, see Additional References.

## Overview of the migration process

The following is an overview of the migration process. You can find more details about the classes in the later part of this document.

1. Import the new [cloud.google.com/go/v2](http://cloud.google.com/go/v2) package.
1. Import the new [cloud.google.com/go/pubsub/v2](http://cloud.google.com/go/pubsub/v2) package.
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot May 22, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

security-medium medium

The link should use https instead of http for consistency and security.

Suggested change
1. Import the new [cloud.google.com/go/pubsub/v2](http://cloud.google.com/go/pubsub/v2) package.
1. Import the new [cloud.google.com/go/pubsub/v2](https://cloud.google.com/go/pubsub/v2) package.


2. Migrate admin operations such as `CreateTopic` and `DeleteTopic` to the v2 version admin API.

Expand Down Expand Up @@ -537,7 +537,7 @@ Because of the change to the data plane clients (now named `Publisher` and `Subs

**Q: Why does the new admin API package mention both v2 and apiv1?**

The new Pub/Sub v2 package is `cloud.google.com/go/v2`. All of the new v2 code lives in the v2 directory. The apiv1 version denotes that the Pub/Sub server API is still under v1 and is **not** changing.
The new Pub/Sub v2 package is `cloud.google.com/go/pubsub/v2`. All of the new v2 code lives in the v2 directory. The apiv1 version denotes that the Pub/Sub server API is still under v1 and is **not** changing.

**Q: Why are you changing the admin API surface?**

Expand Down
Loading