-
Notifications
You must be signed in to change notification settings - Fork 1.5k
feat(bigtable): add opensession descriptors for bigtable #14647
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,133 @@ | ||
| // Copyright 2026 Google LLC | ||
| // | ||
| // Licensed under the Apache License, Version 2.0 (the "License"); | ||
| // you may not use this file except in compliance with the License. | ||
| // You may obtain a copy of the License at | ||
| // | ||
| // http://www.apache.org/licenses/LICENSE-2.0 | ||
| // | ||
| // Unless required by applicable law or agreed to in writing, software | ||
| // distributed under the License is distributed on an "AS IS" BASIS, | ||
| // WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| // See the License for the specific language governing permissions and | ||
| // limitations under the License. | ||
|
|
||
| package internal | ||
|
|
||
| import ( | ||
| "fmt" | ||
|
|
||
| spb "cloud.google.com/go/bigtable/apiv2/bigtablepb" | ||
| "google.golang.org/protobuf/proto" | ||
| ) | ||
|
|
||
| // SessionType represents the protocol target session type. | ||
| type SessionType int | ||
|
|
||
| const ( | ||
| // SessionTypeTable indicates standard table session type. | ||
| SessionTypeTable SessionType = iota | ||
| // SessionTypeAuthorizedView indicates authorized view session type. | ||
| SessionTypeAuthorizedView | ||
| // SessionTypeMaterializedView indicates materialized view session type. | ||
| SessionTypeMaterializedView | ||
| ) | ||
|
|
||
| func (t SessionType) String() string { | ||
| switch t { | ||
| case SessionTypeTable: | ||
| return "table" | ||
| case SessionTypeAuthorizedView: | ||
| return "authorized_view" | ||
| case SessionTypeMaterializedView: | ||
| return "materialized_view" | ||
| default: | ||
| return "unknown" | ||
| } | ||
| } | ||
|
|
||
| // SessionDescriptor models a dynamic envelope handshake parameters compiler. | ||
| type SessionDescriptor struct { | ||
| Type SessionType | ||
| MethodName string | ||
| HeaderKeys []string | ||
| LogNameFn func(req proto.Message) string | ||
| MetadataFn func(req proto.Message) map[string]string // Populates session metadata headers required for OpenSession{} RPC | ||
| } | ||
|
|
||
| var ( | ||
| // TABLE_SESSION manages standard table scoped Session streams. | ||
| TABLE_SESSION = &SessionDescriptor{ | ||
| Type: SessionTypeTable, | ||
| MethodName: "OpenTable", | ||
| HeaderKeys: []string{"table_name", "app_profile_id", "permission"}, | ||
| LogNameFn: func(req proto.Message) string { | ||
| r, ok := req.(*spb.OpenTableRequest) | ||
| if !ok || r == nil { | ||
| return "TableSession(nil)" | ||
| } | ||
| return fmt.Sprintf("TableSession(table=%s, app_profile=%s, perm=%s)", r.TableName, r.AppProfileId, r.Permission.String()) | ||
| }, | ||
| MetadataFn: func(req proto.Message) map[string]string { | ||
| r, ok := req.(*spb.OpenTableRequest) | ||
| if !ok || r == nil { | ||
| return nil | ||
| } | ||
| return map[string]string{ | ||
| "open_session.payload.table_name": r.TableName, | ||
| "open_session.payload.app_profile_id": r.AppProfileId, | ||
| "open_session.payload.permission": r.Permission.String(), | ||
| } | ||
| }, | ||
| } | ||
|
|
||
| // AUTHORIZED_VIEW_SESSION manages authorized view scoped Session streams. | ||
| AUTHORIZED_VIEW_SESSION = &SessionDescriptor{ | ||
| Type: SessionTypeAuthorizedView, | ||
| MethodName: "OpenAuthorizedView", | ||
| HeaderKeys: []string{"authorized_view_name", "app_profile_id", "permission"}, | ||
| LogNameFn: func(req proto.Message) string { | ||
| r, ok := req.(*spb.OpenAuthorizedViewRequest) | ||
| if !ok || r == nil { | ||
| return "AuthorizedViewSession(nil)" | ||
| } | ||
| return fmt.Sprintf("AuthorizedViewSession(view=%s, app_profile=%s, perm=%s)", r.AuthorizedViewName, r.AppProfileId, r.Permission.String()) | ||
| }, | ||
| MetadataFn: func(req proto.Message) map[string]string { | ||
| r, ok := req.(*spb.OpenAuthorizedViewRequest) | ||
| if !ok || r == nil { | ||
| return nil | ||
| } | ||
| return map[string]string{ | ||
| "open_session.payload.authorized_view_name": r.AuthorizedViewName, | ||
| "open_session.payload.app_profile_id": r.AppProfileId, | ||
| "open_session.payload.permission": r.Permission.String(), | ||
| } | ||
| }, | ||
|
sushanb marked this conversation as resolved.
|
||
| } | ||
|
|
||
| // MATERIALIZED_VIEW_SESSION manages materialized view scoped Session streams (Read-Only). | ||
| MATERIALIZED_VIEW_SESSION = &SessionDescriptor{ | ||
| Type: SessionTypeMaterializedView, | ||
| MethodName: "OpenMaterializedView", | ||
| HeaderKeys: []string{"materialized_view_name", "app_profile_id", "permission"}, | ||
| LogNameFn: func(req proto.Message) string { | ||
| r, ok := req.(*spb.OpenMaterializedViewRequest) | ||
| if !ok || r == nil { | ||
| return "MaterializedViewSession(nil)" | ||
| } | ||
| return fmt.Sprintf("MaterializedViewSession(view=%s, app_profile=%s, perm=%s)", r.MaterializedViewName, r.AppProfileId, r.Permission.String()) | ||
| }, | ||
| MetadataFn: func(req proto.Message) map[string]string { | ||
| r, ok := req.(*spb.OpenMaterializedViewRequest) | ||
| if !ok || r == nil { | ||
| return nil | ||
| } | ||
| return map[string]string{ | ||
| "open_session.payload.materialized_view_name": r.MaterializedViewName, | ||
| "open_session.payload.app_profile_id": r.AppProfileId, | ||
| "open_session.payload.permission": r.Permission.String(), | ||
| } | ||
| }, | ||
|
sushanb marked this conversation as resolved.
|
||
| } | ||
| ) | ||
217 changes: 217 additions & 0 deletions
217
bigtable/internal/transport/session_descriptors_test.go
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,217 @@ | ||
| // Copyright 2026 Google LLC | ||
| // | ||
| // Licensed under the Apache License, Version 2.0 (the "License"); | ||
| // you may not use this file except in compliance with the License. | ||
| // You may obtain a copy of the License at | ||
| // | ||
| // http://www.apache.org/licenses/LICENSE-2.0 | ||
| // | ||
| // Unless required by applicable law or agreed to in writing, software | ||
| // distributed under the License is distributed on an "AS IS" BASIS, | ||
| // WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| // See the License for the specific language governing permissions and | ||
| // limitations under the License. | ||
|
|
||
| package internal | ||
|
|
||
| import ( | ||
| "testing" | ||
|
|
||
| spb "cloud.google.com/go/bigtable/apiv2/bigtablepb" | ||
| ) | ||
|
|
||
| func TestSessionType_String(t *testing.T) { | ||
| tests := []struct { | ||
| t SessionType | ||
| want string | ||
| }{ | ||
| {SessionTypeTable, "table"}, | ||
| {SessionTypeAuthorizedView, "authorized_view"}, | ||
| {SessionTypeMaterializedView, "materialized_view"}, | ||
| {SessionType(99), "unknown"}, | ||
| } | ||
|
|
||
| for _, tt := range tests { | ||
| if got := tt.t.String(); got != tt.want { | ||
| t.Errorf("SessionType(%d).String() = %q, want %q", int(tt.t), got, tt.want) | ||
| } | ||
| } | ||
| } | ||
|
|
||
| func TestTableSessionDescriptor(t *testing.T) { | ||
| desc := TABLE_SESSION | ||
|
|
||
| if desc.Type != SessionTypeTable { | ||
| t.Errorf("Expected type %v, got %v", SessionTypeTable, desc.Type) | ||
| } | ||
| if desc.MethodName != "OpenTable" { | ||
| t.Errorf("Expected MethodName 'OpenTable', got %q", desc.MethodName) | ||
| } | ||
|
|
||
| expectedHeaders := []string{"table_name", "app_profile_id", "permission"} | ||
| if len(desc.HeaderKeys) != len(expectedHeaders) { | ||
| t.Fatalf("Expected HeaderKeys length %d, got %d", len(expectedHeaders), len(desc.HeaderKeys)) | ||
| } | ||
| for i, h := range expectedHeaders { | ||
| if desc.HeaderKeys[i] != h { | ||
| t.Errorf("At index %d: expected header key %q, got %q", i, h, desc.HeaderKeys[i]) | ||
| } | ||
| } | ||
|
|
||
| req := &spb.OpenTableRequest{ | ||
| TableName: "projects/p/instances/i/tables/t", | ||
| AppProfileId: "app-profile-1", | ||
| Permission: spb.OpenTableRequest_PERMISSION_READ_WRITE, | ||
| } | ||
|
|
||
| // Test LogNameFn | ||
| logName := desc.LogNameFn(req) | ||
| expectedLogName := "TableSession(table=projects/p/instances/i/tables/t, app_profile=app-profile-1, perm=PERMISSION_READ_WRITE)" | ||
| if logName != expectedLogName { | ||
| t.Errorf("Expected log name %q, got %q", expectedLogName, logName) | ||
| } | ||
|
|
||
| // Test MetadataFn | ||
| meta := desc.MetadataFn(req) | ||
| expectedMeta := map[string]string{ | ||
| "open_session.payload.table_name": "projects/p/instances/i/tables/t", | ||
| "open_session.payload.app_profile_id": "app-profile-1", | ||
| "open_session.payload.permission": "PERMISSION_READ_WRITE", | ||
| } | ||
| if len(meta) != len(expectedMeta) { | ||
| t.Fatalf("Expected metadata length %d, got %d", len(expectedMeta), len(meta)) | ||
| } | ||
| for k, v := range expectedMeta { | ||
| if meta[k] != v { | ||
| t.Errorf("Metadata key %q: expected value %q, got %q", k, v, meta[k]) | ||
| } | ||
| } | ||
| } | ||
|
|
||
| func TestAuthorizedViewSessionDescriptor(t *testing.T) { | ||
| desc := AUTHORIZED_VIEW_SESSION | ||
|
|
||
| if desc.Type != SessionTypeAuthorizedView { | ||
| t.Errorf("Expected type %v, got %v", SessionTypeAuthorizedView, desc.Type) | ||
| } | ||
| if desc.MethodName != "OpenAuthorizedView" { | ||
| t.Errorf("Expected MethodName 'OpenAuthorizedView', got %q", desc.MethodName) | ||
| } | ||
|
|
||
| expectedHeaders := []string{"authorized_view_name", "app_profile_id", "permission"} | ||
| if len(desc.HeaderKeys) != len(expectedHeaders) { | ||
| t.Fatalf("Expected HeaderKeys length %d, got %d", len(expectedHeaders), len(desc.HeaderKeys)) | ||
| } | ||
| for i, h := range expectedHeaders { | ||
| if desc.HeaderKeys[i] != h { | ||
| t.Errorf("At index %d: expected header key %q, got %q", i, h, desc.HeaderKeys[i]) | ||
| } | ||
| } | ||
|
|
||
| req := &spb.OpenAuthorizedViewRequest{ | ||
| AuthorizedViewName: "projects/p/instances/i/tables/t/authorizedViews/v", | ||
| AppProfileId: "app-profile-2", | ||
| Permission: spb.OpenAuthorizedViewRequest_PERMISSION_READ, | ||
| } | ||
|
|
||
| // Test LogNameFn | ||
| logName := desc.LogNameFn(req) | ||
| expectedLogName := "AuthorizedViewSession(view=projects/p/instances/i/tables/t/authorizedViews/v, app_profile=app-profile-2, perm=PERMISSION_READ)" | ||
| if logName != expectedLogName { | ||
| t.Errorf("Expected log name %q, got %q", expectedLogName, logName) | ||
| } | ||
|
|
||
| // Test MetadataFn | ||
| meta := desc.MetadataFn(req) | ||
| expectedMeta := map[string]string{ | ||
| "open_session.payload.authorized_view_name": "projects/p/instances/i/tables/t/authorizedViews/v", | ||
| "open_session.payload.app_profile_id": "app-profile-2", | ||
| "open_session.payload.permission": "PERMISSION_READ", | ||
| } | ||
| if len(meta) != len(expectedMeta) { | ||
| t.Fatalf("Expected metadata length %d, got %d", len(expectedMeta), len(meta)) | ||
| } | ||
| for k, v := range expectedMeta { | ||
| if meta[k] != v { | ||
| t.Errorf("Metadata key %q: expected value %q, got %q", k, v, meta[k]) | ||
| } | ||
| } | ||
| } | ||
|
|
||
| func TestMaterializedViewSessionDescriptor(t *testing.T) { | ||
| desc := MATERIALIZED_VIEW_SESSION | ||
|
|
||
| if desc.Type != SessionTypeMaterializedView { | ||
| t.Errorf("Expected type %v, got %v", SessionTypeMaterializedView, desc.Type) | ||
| } | ||
| if desc.MethodName != "OpenMaterializedView" { | ||
| t.Errorf("Expected MethodName 'OpenMaterializedView', got %q", desc.MethodName) | ||
| } | ||
|
|
||
| expectedHeaders := []string{"materialized_view_name", "app_profile_id", "permission"} | ||
| if len(desc.HeaderKeys) != len(expectedHeaders) { | ||
| t.Fatalf("Expected HeaderKeys length %d, got %d", len(expectedHeaders), len(desc.HeaderKeys)) | ||
| } | ||
| for i, h := range expectedHeaders { | ||
| if desc.HeaderKeys[i] != h { | ||
| t.Errorf("At index %d: expected header key %q, got %q", i, h, desc.HeaderKeys[i]) | ||
| } | ||
| } | ||
|
|
||
| req := &spb.OpenMaterializedViewRequest{ | ||
| MaterializedViewName: "projects/p/instances/i/materializedViews/mv", | ||
| AppProfileId: "app-profile-3", | ||
| Permission: spb.OpenMaterializedViewRequest_PERMISSION_READ, | ||
| } | ||
|
|
||
| // Test LogNameFn | ||
| logName := desc.LogNameFn(req) | ||
| expectedLogName := "MaterializedViewSession(view=projects/p/instances/i/materializedViews/mv, app_profile=app-profile-3, perm=PERMISSION_READ)" | ||
| if logName != expectedLogName { | ||
| t.Errorf("Expected log name %q, got %q", expectedLogName, logName) | ||
| } | ||
|
|
||
| // Test MetadataFn | ||
| meta := desc.MetadataFn(req) | ||
| expectedMeta := map[string]string{ | ||
| "open_session.payload.materialized_view_name": "projects/p/instances/i/materializedViews/mv", | ||
| "open_session.payload.app_profile_id": "app-profile-3", | ||
| "open_session.payload.permission": "PERMISSION_READ", | ||
| } | ||
| if len(meta) != len(expectedMeta) { | ||
| t.Fatalf("Expected metadata length %d, got %d", len(expectedMeta), len(meta)) | ||
| } | ||
| for k, v := range expectedMeta { | ||
| if meta[k] != v { | ||
| t.Errorf("Metadata key %q: expected value %q, got %q", k, v, meta[k]) | ||
| } | ||
| } | ||
| } | ||
|
|
||
| func TestSessionDescriptors_SafeAssertions(t *testing.T) { | ||
| // 1. Verify with nil request | ||
| if name := TABLE_SESSION.LogNameFn(nil); name != "TableSession(nil)" { | ||
| t.Errorf("Expected LogNameFn(nil) = 'TableSession(nil)', got %q", name) | ||
| } | ||
| if meta := TABLE_SESSION.MetadataFn(nil); meta != nil { | ||
| t.Errorf("Expected MetadataFn(nil) = nil, got %v", meta) | ||
| } | ||
|
|
||
| // 2. Verify with typed nil pointer | ||
| var nilTableReq *spb.OpenTableRequest | ||
| if name := TABLE_SESSION.LogNameFn(nilTableReq); name != "TableSession(nil)" { | ||
| t.Errorf("Expected LogNameFn(typed nil) = 'TableSession(nil)', got %q", name) | ||
| } | ||
| if meta := TABLE_SESSION.MetadataFn(nilTableReq); meta != nil { | ||
| t.Errorf("Expected MetadataFn(typed nil) = nil, got %v", meta) | ||
| } | ||
|
|
||
| // 3. Verify with wrong message type | ||
| wrongReq := &spb.OpenAuthorizedViewRequest{} | ||
| if name := TABLE_SESSION.LogNameFn(wrongReq); name != "TableSession(nil)" { | ||
| t.Errorf("Expected LogNameFn(wrong type) = 'TableSession(nil)', got %q", name) | ||
| } | ||
| if meta := TABLE_SESSION.MetadataFn(wrongReq); meta != nil { | ||
| t.Errorf("Expected MetadataFn(wrong type) = nil, got %v", meta) | ||
| } | ||
| } |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.