feat(bigtable): add virtual RPC descriptors #14648
Open
sushanb wants to merge 3 commits into
Open
Conversation
sushanb
changed the title
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request introduces a virtual RPC encoding and decoding framework for Bigtable, including descriptors for standard tables, authorized views, and materialized views, along with comprehensive unit tests. The review feedback highlights a critical performance issue where nested protobuf messages are redundantly marshaled and unmarshaled on the hot path, and suggests refactoring the signatures to pass typed proto messages directly. Additionally, the feedback recommends consolidating duplicate imports of the bigtablepb package and updating the factories and descriptors to use a single alias for better readability.
product-auto-label
Bot
added
the
api: bigtable
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.