Skip to content

feat(storage): Add client feature tracking in HTTP client#14691

Open
krishnamd-jkp wants to merge 2 commits into
googleapis:mainfrom
krishnamd-jkp:http-tracker
Open

feat(storage): Add client feature tracking in HTTP client#14691
krishnamd-jkp wants to merge 2 commits into
googleapis:mainfrom
krishnamd-jkp:http-tracker

Conversation

@krishnamd-jkp
Copy link
Copy Markdown
Contributor

No description provided.

@krishnamd-jkp krishnamd-jkp requested review from a team as code owners June 1, 2026 09:06
@product-auto-label product-auto-label Bot added the api: storage Issues related to the Cloud Storage API. label Jun 1, 2026
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request implements feature tracking headers for the HTTP storage client by introducing a trackingTransport that wraps the client's base transport and injects feature attributes into outgoing requests. Review feedback highlights two critical issues: first, configFeatureAttributes is never initialized in newHTTPStorageClient, meaning client-level features are not currently tracked; second, trackingTransport does not implement CloseIdleConnections(), which will cause Close() to be a no-op and potentially leak idle connections.

Comment thread storage/http_client.go
Comment thread storage/http_client.go
@krishnamd-jkp
Copy link
Copy Markdown
Contributor Author

/gemini review

Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request implements client-level feature tracking for the HTTP storage client by wrapping the transport in a custom trackingTransport to inject tracking headers. However, the configFeatureAttributes field in httpStorageClient is never initialized in newHTTPStorageClient, which prevents client-level features from being tracked. A suggestion has been provided to initialize this field with config.featureAttributes.

Comment thread storage/http_client.go
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api: storage Issues related to the Cloud Storage API.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant