feat(storage): Add client feature tracking in HTTP client#14691
feat(storage): Add client feature tracking in HTTP client#14691krishnamd-jkp wants to merge 2 commits into
Conversation
There was a problem hiding this comment.
Code Review
This pull request implements feature tracking headers for the HTTP storage client by introducing a trackingTransport that wraps the client's base transport and injects feature attributes into outgoing requests. Review feedback highlights two critical issues: first, configFeatureAttributes is never initialized in newHTTPStorageClient, meaning client-level features are not currently tracked; second, trackingTransport does not implement CloseIdleConnections(), which will cause Close() to be a no-op and potentially leak idle connections.
|
/gemini review |
There was a problem hiding this comment.
Code Review
This pull request implements client-level feature tracking for the HTTP storage client by wrapping the transport in a custom trackingTransport to inject tracking headers. However, the configFeatureAttributes field in httpStorageClient is never initialized in newHTTPStorageClient, which prevents client-level features from being tracked. A suggestion has been provided to initialize this field with config.featureAttributes.
54ad35d to
a9373a2
Compare
No description provided.