chore(librariangen): update snippet metadata in both directories#14692
Open
JoeWang1127 wants to merge 8 commits into
Open
chore(librariangen): update snippet metadata in both directories#14692JoeWang1127 wants to merge 8 commits into
JoeWang1127 wants to merge 8 commits into
Conversation
Contributor
There was a problem hiding this comment.
Code Review
This pull request updates the snippet metadata processing to support reading and updating metadata files from two distinct directories: the shared snippets directory and the examples directory. While the added unit tests successfully cover these new scenarios, the current implementation introduces non-determinism by iterating over a map and silently ignores cases where neither file is found. It is recommended to refactor the logic using a slice of paths to ensure deterministic processing, reduce duplication, and preserve the original logging behavior when files are missing.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updates the
UpdateSnippetsMetadatalogic in the legacylibrarian Go container to support and update snippet metadata files in both:internal/generated/snippets/<moduleName>)examplesdirectory (<moduleName>/examples)Fixes googleapis/librarian#6257