Skip to content

fix: onboarding libraries to Librarian / automl, run, and iam - #36534

Merged
suztomo merged 2 commits into
googleapis:mainfrom
suztomo:chore/onboarding-batch-automl-run-iam
Sep 8, 2026
Merged

suztomo merged 2 commits into
googleapis:mainfrom
suztomo:chore/onboarding-batch-automl-run-iam

Conversation

@suztomo

@suztomo suztomo commented Sep 8, 2026

Copy link
Copy Markdown
Member

Summary

Onboards 4 libraries from OwlBot to Librarian (v0.40.1-0.20260904160715-39fbb3f6fecb) using gapic-generator-cloud 0.52.0 (#36532):

  1. google-cloud-automl-v1 (unblocked by gapic-generator-ruby#1340 / librarian#7465)
  2. google-cloud-automl-v1beta1 (unblocked by gapic-generator-ruby#1340 / librarian#7465)
  3. google-cloud-run-client (unblocked by ruby-cloud-renamed-from=google-cloud-run in librarian#7500 & gapic-generator-ruby#1342 / librarian#7447)
  4. google-iam-client (unblocked by ruby-cloud-renamed-from=google-iam in librarian#7500 & gapic-generator-ruby#1342 / librarian#7447)

See tracking spreadsheet: go/sdk-librarian-ruby-tracker


Analysis of Code Diffs

Standard Expected Changes

  • OwlBot Removal: Deleted .OwlBot.yaml, .owlbot-manifest.json, and custom .owlbot.rb scripts across all 4 libraries.
  • File Permissions: Snippet script permissions standardized from 100755 to 100644 (librarian#7057).
  • Library Metadata & Documentation Titles:
    • google-cloud-automl-v1beta1/google-cloud-automl-v1beta1.gemspec: Description updated to match service.yaml summary (Train high-quality custom machine learning models with minimum effort and machine learning expertise.).
    • google-cloud-run-client: .yardopts, README.md, and google-cloud-run-client.gemspec title/description updated to match google/cloud/run/v2/run_v2.yaml (Cloud Run Admin API).
    • google-iam-client: .yardopts, README.md, and google-iam-client.gemspec title/description updated to match google/iam/v2/iam_v2.yaml (Identity and Access Management (IAM) API).

Generator & Formatter Improvements (Verified Behaviors)

  • Split URL Rejoining in Proto Docs (google-cloud-automl-v1beta1):
    • In google-cloud-automl-v1beta1/proto_docs/google/cloud/automl/v1beta1/io.rb, URLs split across lines in proto comments (https:\n//cloud.google.com/...) are automatically rejoined into valid single-line Markdown links (https://cloud.google.com/...) via FormattingUtils.format_doc_lines (gapic-generator-ruby#1340).
  • Native Gem Renaming Support (google-cloud-run-client & google-iam-client):
    • Previously, .owlbot.rb post-processing scripts manually renamed google-cloud-run -> google-cloud-run-client and google-iam -> google-iam-client. With ruby-cloud-renamed-from (librarian#7500 and gapic-generator-ruby#1342), the generator natively outputs the renamed gemspec, entrypoint (lib/google-cloud-run-client.rb, lib/google-iam-client.rb), and version constants (Google::Cloud::Run::Client::VERSION, Google::Iam::Client::VERSION) without .owlbot.rb.

Local Verification

Ran toys ci --test --rubocop --doctest across all 4 gems:

  • google-cloud-run-client: 17 runs, 17 assertions, 0 failures, 0 errors, 0 skips; RuboCop: 4 files inspected, 0 offenses
  • google-cloud-automl-v1: 66 runs, 1634 assertions, 0 failures, 0 errors, 0 skips; RuboCop: 45 files inspected, 0 offenses
  • google-cloud-automl-v1beta1: 80 runs, 2018 assertions, 0 failures, 0 errors, 0 skips; RuboCop: 51 files inspected, 0 offenses
  • google-iam-client: 3 runs, 3 assertions, 0 failures, 0 errors, 0 skips; RuboCop: 4 files inspected, 0 offenses

@suztomo
suztomo marked this pull request as ready for review September 8, 2026 15:37
@suztomo
suztomo requested review from a team and yoshi-approver as code owners September 8, 2026 15:37
@suztomo suztomo changed the title fix: onboarding libraries to Librarian / automl-run-iam fix: onboarding libraries to Librarian / automl, run, and iam Sep 8, 2026
@suztomo
suztomo marked this pull request as draft September 8, 2026 15:44
@suztomo

suztomo commented Sep 8, 2026

Copy link
Copy Markdown
Member Author

Checking to see whether I can add the compute libraries here too.

@suztomo

suztomo commented Sep 8, 2026

Copy link
Copy Markdown
Member Author

Checking to see whether I can add the compute libraries here too.

Let's keep the google-cloud-compute and google-cloud-compute-v1 library migration separate because of in-flight proto definition updates #36350.

@suztomo
suztomo marked this pull request as ready for review September 8, 2026 16:02
@@ -1,4 +1,4 @@
# Cloud AutoML V1beta1 Protocol Buffer Documentation
# Cloud AutoML V1BETA1 Protocol Buffer Documentation

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is the format change a result of Librarian auto-generation?

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, this is consistent with other libraries to have upper-case.

@suztomo
suztomo merged commit d12ac11 into googleapis:main Sep 8, 2026
19 checks passed
@suztomo
suztomo deleted the chore/onboarding-batch-automl-run-iam branch September 8, 2026 16:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants