fix: onboarding libraries to Librarian / compute - #36535
Merged
Merged
Conversation
Member
Author
|
The integration tests failed https://paste.googleplex.com/5970813774331904. Probably due to the environment set up is not yet done. The Kokoro job also failed in OwlBot's pull request in #36350. |
aandreassa
approved these changes
Sep 8, 2026
This was referenced Sep 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Onboards
google-cloud-computeandgoogle-cloud-compute-v1from OwlBot to Librarian (v0.40.1-0.20260904160715-39fbb3f6fecb) usinggapic-generator-cloud0.52.0(#36532).Resolves:
ruby: google-cloud-compute-v1)ruby: YARD documentation warning in google-cloud-compute)See tracking spreadsheet:
go/sdk-librarian-ruby-trackerComparison & Diff Analysis vs. OwlBot PR #36350
Pull request #36350 is an open OwlBot PR containing two nested commits from
googleapis:20260807(https://github.com/googleapis/googleapis/commit/32aa4089114a8fbbce1b090244aaf80c6b68f36f):ResourceMetadata,RegexRewrite,FutureReservationStoragePoolProvisionedCapacity,ASNrate-limit key types, etc.googleapiscommit pinned inlibrarian.yaml(00ff8fcb95cafbac573cc449b0d1a039244f1b4b) is an ancestor of32aa4089114a. All proto definitions (lib/google/cloud/compute/v1/compute_pb.rb) and doc updates (proto_docs/google/cloud/compute/v1/compute.rb) from Revision20260807are included in this onboarding PR.20260821(https://github.com/googleapis/googleapis/commit/31daafc7af507fab68f0317a5b15a382ba2c3fda):ReservationSlots.GetHealthRPC (reservation_slots/rest/client.rb,service_stub.rb,reservation_slots_rest_test.rb),GetHealthOperationMetadata, andBMSAIconfidential instance types.googleapisSHA Bump: Because00ff8fcb95caprecedes31daafc7af50, the Revision20260821additions are not yet present inlibrarian.yaml's pinned commit and will be automatically generated and released whensources.googleapis.commitis bumped (tracked under librarian#7386).Analysis of Code Diffs
Standard Expected Changes
.OwlBot.yaml,.owlbot-manifest.json, and custom.owlbot.rbscripts ingoogle-cloud-computeandgoogle-cloud-compute-v1.100755to100644(librarian#7057)..yardopts,README.md,proto_docs/README.md, and gemspec titles/summaries updated to matchgoogle/cloud/compute/v1/compute_v1.yaml(Compute Engine API).Generator & Librarian Improvements (Verified Behaviors)
grpc_tools_ruby_protocunconditionally generatedcompute_services_pb.rb(containing unusedGRPC::GenericServicestubs) for REST-only DIREGAPICs. Withlibrarian#7453,--grpc_outis omitted for REST-only transports, socompute_services_pb.rbis cleanly omitted.delete_generation_output_paths(librarian#7506):.owlbot.rbworkaround (FileUtils.rm_rf File.join(OwlBot.staging_dir, "snippets")) with nativedelete_generation_output_paths: [snippets]configuration inlibrarian.yaml..owlbot.rbregex modifiers for multiline{...}braces and@pattern/@requiredtags with nativegapic-generator-cloud0.52.0formatting.Local Verification
Ran
toys ci --test --rubocop --doctest --yardacross both gems:google-cloud-compute-v1:--fail-on-warning): 87.48% documented, 0 warnings, 0 errorsgoogle-cloud-compute: