Skip to content

fix: onboarding libraries to Librarian / compute - #36535

Merged
suztomo merged 2 commits into
googleapis:mainfrom
suztomo:chore/onboarding-batch-compute
Sep 8, 2026
Merged

suztomo merged 2 commits into
googleapis:mainfrom
suztomo:chore/onboarding-batch-compute

Conversation

@suztomo

@suztomo suztomo commented Sep 8, 2026

Copy link
Copy Markdown
Member

Summary

Onboards google-cloud-compute and google-cloud-compute-v1 from OwlBot to Librarian (v0.40.1-0.20260904160715-39fbb3f6fecb) using gapic-generator-cloud 0.52.0 (#36532).

Resolves:

See tracking spreadsheet: go/sdk-librarian-ruby-tracker


Comparison & Diff Analysis vs. OwlBot PR #36350

Pull request #36350 is an open OwlBot PR containing two nested commits from googleapis:

  1. Revision 20260807 (https://github.com/googleapis/googleapis/commit/32aa4089114a8fbbce1b090244aaf80c6b68f36f):
    • Adds ResourceMetadata, RegexRewrite, FutureReservationStoragePoolProvisionedCapacity, ASN rate-limit key types, etc.
    • Included in this PR: The googleapis commit pinned in librarian.yaml (00ff8fcb95cafbac573cc449b0d1a039244f1b4b) is an ancestor of 32aa4089114a. All proto definitions (lib/google/cloud/compute/v1/compute_pb.rb) and doc updates (proto_docs/google/cloud/compute/v1/compute.rb) from Revision 20260807 are included in this onboarding PR.
  2. Revision 20260821 (https://github.com/googleapis/googleapis/commit/31daafc7af507fab68f0317a5b15a382ba2c3fda):
    • Adds ReservationSlots.GetHealth RPC (reservation_slots/rest/client.rb, service_stub.rb, reservation_slots_rest_test.rb), GetHealthOperationMetadata, and BMSAI confidential instance types.
    • Pending googleapis SHA Bump: Because 00ff8fcb95ca precedes 31daafc7af50, the Revision 20260821 additions are not yet present in librarian.yaml's pinned commit and will be automatically generated and released when sources.googleapis.commit is bumped (tracked under librarian#7386).

Analysis of Code Diffs

Standard Expected Changes

  • OwlBot Removal: Deleted .OwlBot.yaml, .owlbot-manifest.json, and custom .owlbot.rb scripts in google-cloud-compute and google-cloud-compute-v1.
  • File Permissions: Standardized file permissions from 100755 to 100644 (librarian#7057).
  • Library Metadata & Documentation Titles:
    • .yardopts, README.md, proto_docs/README.md, and gemspec titles/summaries updated to match google/cloud/compute/v1/compute_v1.yaml (Compute Engine API).

Generator & Librarian Improvements (Verified Behaviors)

  • REST-Only Transport Proto Generation (librarian#7453):
    • In legacy runs, grpc_tools_ruby_protoc unconditionally generated compute_services_pb.rb (containing unused GRPC::GenericService stubs) for REST-only DIREGAPICs. With librarian#7453, --grpc_out is omitted for REST-only transports, so compute_services_pb.rb is cleanly omitted.
  • Snippets Omission via delete_generation_output_paths (librarian#7506):
    • Replaces the legacy .owlbot.rb workaround (FileUtils.rm_rf File.join(OwlBot.staging_dir, "snippets")) with native delete_generation_output_paths: [snippets] configuration in librarian.yaml.
  • YARD Formatting Fixes (gapic-generator-ruby#1337):
    • Replaces the legacy .owlbot.rb regex modifiers for multiline {...} braces and @pattern/@required tags with native gapic-generator-cloud 0.52.0 formatting.

Local Verification

Ran toys ci --test --rubocop --doctest --yard across both gems:

  • google-cloud-compute-v1:
    • Unit tests: 0 failures, 0 errors
    • RuboCop: 0 offenses
    • YARD (--fail-on-warning): 87.48% documented, 0 warnings, 0 errors
  • google-cloud-compute:
    • Unit tests: 126 runs, 101 assertions, 0 failures, 0 errors
    • RuboCop: 4 files inspected, 0 offenses
    • YARD: 98.43% documented, 0 warnings, 0 errors

@suztomo
suztomo requested review from a team and yoshi-approver as code owners September 8, 2026 17:05
@suztomo

suztomo commented Sep 8, 2026

Copy link
Copy Markdown
Member Author

The integration tests failed https://paste.googleplex.com/5970813774331904. Probably due to the environment set up is not yet done. The Kokoro job also failed in OwlBot's pull request in #36350.

@suztomo
suztomo merged commit 4409af8 into googleapis:main Sep 8, 2026
17 of 19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants