Skip to content

fix: onboarding vision libraries to Librarian - #36538

Merged
suztomo merged 2 commits into
googleapis:mainfrom
suztomo:chore/onboarding-vision
Sep 8, 2026
Merged

suztomo merged 2 commits into
googleapis:mainfrom
suztomo:chore/onboarding-vision

Conversation

@suztomo

@suztomo suztomo commented Sep 8, 2026

Copy link
Copy Markdown
Member

See go/sdk-librarian-ruby-tracker

Summary

Onboards the remaining Cloud Vision versioned client gems to Librarian following the addition of toys_tasks support in Librarian v0.42.0 (googleapis/librarian#7513 / #36536):

  • google-cloud-vision-v1
  • google-cloud-vision-v1p3beta1
  • google-cloud-vision-v1p4beta1

In librarian.yaml:

  • Added toys (version: 0.22.0) under tools.gem.
  • Configured ruby.toys_tasks: ["generate-helpers"] on each Vision library to run .toys/generate-helpers.rb post-generation.

Diff Analysis

  1. OwlBot Removal: Deleted .owlbot.rb, .OwlBot.yaml, and .owlbot-manifest.json across all three libraries.
  2. Library Metadata & Documentation:
    • gemspec description updated to match service.yaml (Integrates Google Vision features...).
    • Version title casing in README.md, .yardopts, and proto_docs/README.md normalized (V1p3beta1 -> V1P3BETA1, V1p4beta1 -> V1P4BETA1).
  3. File Permissions: Snippet script permissions corrected from 100755 to 100644.
  4. Generated Helper Methods: All custom Vision helper methods (helpers.rb, image_annotator_helpers_test.rb, helpers_smoke_test.rb) were cleanly generated via .toys/generate-helpers.rb with zero diff against the existing files.

Verification

Ran unit tests, RuboCop, and doctests locally:

toys ci --test --rubocop --doctest --gems google-cloud-vision-v1,google-cloud-vision-v1p3beta1,google-cloud-vision-v1p4beta1

All tests and RuboCop checks passed with 0 failures and 0 offenses.

@suztomo
suztomo marked this pull request as ready for review September 8, 2026 21:29
@suztomo
suztomo requested review from a team and yoshi-approver as code owners September 8, 2026 21:29
@suztomo
suztomo force-pushed the chore/onboarding-vision branch from a360706 to 829bac5 Compare September 8, 2026 21:42
@aandreassa

Copy link
Copy Markdown
Contributor

Are we missing google-cloud-vision_ai-v1? Either way how you want to do it.

@suztomo

suztomo commented Sep 8, 2026

Copy link
Copy Markdown
Member Author

For google-cloud-vision_ai-v1, it's a remaining issue googleapis/librarian#7505. Joe and I are trying to fix the source of the bad, unmatched quotations in google3.

@suztomo
suztomo merged commit f8fef7e into googleapis:main Sep 8, 2026
19 checks passed
@suztomo
suztomo deleted the chore/onboarding-vision branch September 8, 2026 22:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants