fix: onboarding vision libraries to Librarian - #36538
Merged
Merged
Conversation
suztomo
marked this pull request as ready for review
September 8, 2026 21:29
suztomo
force-pushed
the
chore/onboarding-vision
branch
from
September 8, 2026 21:42
a360706 to
829bac5
Compare
aandreassa
approved these changes
Sep 8, 2026
Contributor
|
Are we missing |
Member
Author
|
For google-cloud-vision_ai-v1, it's a remaining issue googleapis/librarian#7505. Joe and I are trying to fix the source of the bad, unmatched quotations in google3. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See go/sdk-librarian-ruby-tracker
Summary
Onboards the remaining Cloud Vision versioned client gems to Librarian following the addition of
toys_taskssupport in Librarian v0.42.0 (googleapis/librarian#7513 / #36536):google-cloud-vision-v1google-cloud-vision-v1p3beta1google-cloud-vision-v1p4beta1In
librarian.yaml:toys(version: 0.22.0) undertools.gem.ruby.toys_tasks: ["generate-helpers"]on each Vision library to run.toys/generate-helpers.rbpost-generation.Diff Analysis
.owlbot.rb,.OwlBot.yaml, and.owlbot-manifest.jsonacross all three libraries.gemspecdescription updated to matchservice.yaml(Integrates Google Vision features...).README.md,.yardopts, andproto_docs/README.mdnormalized (V1p3beta1->V1P3BETA1,V1p4beta1->V1P4BETA1).100755to100644.helpers.rb,image_annotator_helpers_test.rb,helpers_smoke_test.rb) were cleanly generated via.toys/generate-helpers.rbwith zero diff against the existing files.Verification
Ran unit tests, RuboCop, and doctests locally:
All tests and RuboCop checks passed with 0 failures and 0 offenses.