feat(storage): implement replay buffer for appendable upload - #6605
Merged
Merged
Conversation
product-auto-label
Bot
added
the
api: storage
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request introduces a new ReplayBuffer module to manage unacknowledged data chunks, trim acknowledged data, and support resending chunks upon stream reconnection. The reviewer suggested refactoring the acknowledge method to separate the loop logic and adding a safety comment explaining the invariants when slicing the chunk data.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #6605 +/- ##
==========================================
- Coverage 97.17% 97.17% -0.01%
==========================================
Files 328 329 +1
Lines 109802 109974 +172
==========================================
+ Hits 106702 106867 +165
- Misses 3100 3107 +7 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
vsharonlynn
marked this pull request as ready for review
September 1, 2026 07:37
vsharonlynn
force-pushed
the
replay-foundation
branch
from
September 1, 2026 08:07
0ae57e5 to
4ccbe87
Compare
coryan
reviewed
Sep 1, 2026
joshuatants
previously requested changes
Sep 3, 2026
vsharonlynn
force-pushed
the
replay-foundation
branch
from
September 8, 2026 05:50
4ccbe87 to
cdefb94
Compare
vsharonlynn
changed the title
xlai20
requested changes
Sep 17, 2026
xlai20
left a comment
xlai20
left a comment
Member
There was a problem hiding this comment.
I would say it's in general a ready to merge state except 2 nits.
- Drop the unreachable expect() by reading the front chunk length before popping it, removing the redundant panic branch. - Relabel the // SAFETY: comment as // Invariant:, since Bytes::slice is safe Rust and the comment documents an algorithmic invariant, not an unsafe contract.
vsharonlynn
force-pushed
the
replay-foundation
branch
from
September 17, 2026 13:21
cdefb94 to
2814ea2
Compare
xlai20
approved these changes
Sep 18, 2026
vsharonlynn
dismissed
joshuatants’s stale review
September 18, 2026 06:30
Olivia has approved. Thanks!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue #5716 .