chore(bigquery): send veneer header instead of gapic - #6848
Merged
alvarowolfx merged 1 commit intoSep 18, 2026
Merged
Conversation
Contributor
There was a problem hiding this comment.
Code Review
This pull request adds the httptest development dependency to the bigquery crate and configures the BigQuery client to include the XGoogApiClient extension, which sets the x-goog-api-client header to indicate a veneer library (gccl) with the package version. A new integration test has been added to verify that the correct header is sent and does not contain the gapic identifier. I have no feedback to provide as the changes are well-implemented and include appropriate test coverage.
alvarowolfx
marked this pull request as ready for review
September 17, 2026 20:47
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #6848 +/- ##
==========================================
- Coverage 97.18% 97.18% -0.01%
==========================================
Files 328 328
Lines 109962 110003 +41
==========================================
+ Hits 106867 106902 +35
- Misses 3095 3101 +6 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Towards #2138