Skip to content

chore(bigquery): send veneer header instead of gapic - #6848

Merged
alvarowolfx merged 1 commit into
googleapis:mainfrom
alvarowolfx:chore-bq-advertise-as-veneer
Sep 18, 2026
Merged

alvarowolfx merged 1 commit into
googleapis:mainfrom
alvarowolfx:chore-bq-advertise-as-veneer

Conversation

@alvarowolfx

Copy link
Copy Markdown
Contributor

Towards #2138

@product-auto-label product-auto-label Bot added the api: bigquery Issues related to the BigQuery API. label Sep 17, 2026

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request adds the httptest development dependency to the bigquery crate and configures the BigQuery client to include the XGoogApiClient extension, which sets the x-goog-api-client header to indicate a veneer library (gccl) with the package version. A new integration test has been added to verify that the correct header is sent and does not contain the gapic identifier. I have no feedback to provide as the changes are well-implemented and include appropriate test coverage.

@alvarowolfx
alvarowolfx marked this pull request as ready for review September 17, 2026 20:47
@alvarowolfx
alvarowolfx requested a review from a team as a code owner September 17, 2026 20:47
@codecov

codecov Bot commented Sep 17, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 97.18%. Comparing base (e295fe6) to head (84bacc0).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6848      +/-   ##
==========================================
- Coverage   97.18%   97.18%   -0.01%     
==========================================
  Files         328      328              
  Lines      109962   110003      +41     
==========================================
+ Hits       106867   106902      +35     
- Misses       3095     3101       +6     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@dbolduc dbolduc left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice

@alvarowolfx
alvarowolfx merged commit b272b10 into googleapis:main Sep 18, 2026
42 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api: bigquery Issues related to the BigQuery API.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants