refactor(bigquery): genericize DefaultWriter - #6860
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Code Review
This pull request refactors DefaultWriter to be generic over the data format (DefaultWriter<F>), moving it to a shared write module to support both Arrow and Proto formats. Feedback on these changes includes correcting the import paths in the tests module of default.rs to use super:: instead of super::super::, and deriving Clone on DefaultWriter to facilitate sharing across asynchronous tasks without introducing double indirection.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #6860 +/- ##
==========================================
- Coverage 97.18% 97.18% -0.01%
==========================================
Files 331 330 -1
Lines 110482 110394 -88
==========================================
- Hits 107373 107283 -90
- Misses 3109 3111 +2 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
dbolduc
commented
Sep 18, 2026
dbolduc
marked this pull request as ready for review
September 18, 2026 22:15
haphungw
approved these changes
Sep 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR refactors the
arrow::DefaultWriterandproto::DefaultWriterto share a common implementation.The
crate::write:::DefaultWriter<F>is ultimately the type we want to expose to applications. By the end of #6855 we will delete the other versions.I decided we should expose the final types now because the docs are unusable if we try to hide them:
https://screenshot-v2.corp.google.com/1c0t3ta9teocg
vs.
https://screenshot-v2.corp.google.com/2fm1nq03p61g0
Towards #6855, #6762