-
Notifications
You must be signed in to change notification settings - Fork 94
chore: demo of changes from sdk-platform-java#3737 #3029
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,38 @@ | ||
| # Format: //devtools/kokoro/config/proto/build.proto | ||
|
|
||
| # Configure the docker image for kokoro-trampoline. | ||
| env_vars: { | ||
| key: "TRAMPOLINE_IMAGE" | ||
| value: "gcr.io/cloud-devrel-public-resources/graalvm_sdk_platform_b:3.45.1" | ||
| } | ||
|
|
||
| env_vars: { | ||
| key: "JOB_TYPE" | ||
| value: "graalvm" | ||
| } | ||
|
|
||
| # TODO: remove this after we've migrated all tests and scripts | ||
| env_vars: { | ||
| key: "GCLOUD_PROJECT" | ||
| value: "gcloud-devel" | ||
| } | ||
|
|
||
| env_vars: { | ||
| key: "GOOGLE_CLOUD_PROJECT" | ||
| value: "gcloud-devel" | ||
| } | ||
|
|
||
| env_vars: { | ||
| key: "GOOGLE_APPLICATION_CREDENTIALS" | ||
| value: "secret_manager/java-it-service-account" | ||
| } | ||
|
|
||
| env_vars: { | ||
| key: "SECRET_MANAGER_KEYS" | ||
| value: "java-it-service-account" | ||
| } | ||
|
|
||
| env_vars: { | ||
| key: "IT_SERVICE_ACCOUNT_EMAIL" | ||
| value: "it-service-account@gcloud-devel.iam.gserviceaccount.com" | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,38 @@ | ||
| # Format: //devtools/kokoro/config/proto/build.proto | ||
|
|
||
| # Configure the docker image for kokoro-trampoline. | ||
| env_vars: { | ||
| key: "TRAMPOLINE_IMAGE" | ||
| value: "gcr.io/cloud-devrel-public-resources/graalvm_sdk_platform_b:3.45.1" | ||
| } | ||
|
|
||
| env_vars: { | ||
| key: "JOB_TYPE" | ||
| value: "graalvm" | ||
| } | ||
|
|
||
| # TODO: remove this after we've migrated all tests and scripts | ||
| env_vars: { | ||
| key: "GCLOUD_PROJECT" | ||
| value: "gcloud-devel" | ||
| } | ||
|
|
||
| env_vars: { | ||
| key: "GOOGLE_CLOUD_PROJECT" | ||
| value: "gcloud-devel" | ||
| } | ||
|
|
||
| env_vars: { | ||
| key: "GOOGLE_APPLICATION_CREDENTIALS" | ||
| value: "secret_manager/java-it-service-account" | ||
| } | ||
|
|
||
| env_vars: { | ||
| key: "SECRET_MANAGER_KEYS" | ||
| value: "java-it-service-account" | ||
| } | ||
|
|
||
| env_vars: { | ||
| key: "IT_SERVICE_ACCOUNT_EMAIL" | ||
| value: "it-service-account@gcloud-devel.iam.gserviceaccount.com" | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,38 @@ | ||
| # Format: //devtools/kokoro/config/proto/build.proto | ||
|
|
||
| # Configure the docker image for kokoro-trampoline. | ||
| env_vars: { | ||
| key: "TRAMPOLINE_IMAGE" | ||
| value: "gcr.io/cloud-devrel-public-resources/graalvm_sdk_platform_b:3.45.1" | ||
| } | ||
|
|
||
| env_vars: { | ||
| key: "JOB_TYPE" | ||
| value: "graalvm" | ||
| } | ||
|
|
||
| # TODO: remove this after we've migrated all tests and scripts | ||
| env_vars: { | ||
| key: "GCLOUD_PROJECT" | ||
| value: "gcloud-devel" | ||
| } | ||
|
|
||
| env_vars: { | ||
| key: "GOOGLE_CLOUD_PROJECT" | ||
| value: "gcloud-devel" | ||
| } | ||
|
|
||
| env_vars: { | ||
| key: "GOOGLE_APPLICATION_CREDENTIALS" | ||
| value: "secret_manager/java-it-service-account" | ||
| } | ||
|
|
||
| env_vars: { | ||
| key: "SECRET_MANAGER_KEYS" | ||
| value: "java-it-service-account" | ||
| } | ||
|
|
||
| env_vars: { | ||
| key: "IT_SERVICE_ACCOUNT_EMAIL" | ||
| value: "it-service-account@gcloud-devel.iam.gserviceaccount.com" | ||
| } | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we should remove the existing graalvm configs if these are going to replace them
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for pointing it out. Although this is just a draft, I was thinking of manually remove them once the generator image brings these templates (the generator doesn't remove templated files). I'll keep you posted with our decision.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Two steps is okay in my mind, but it will put extra strain on the native image build pool have 5 configs instead of the 2 today or 3 tomorrow.
We'll also need to update the https://github.com/googleapis/java-storage/blob/main/.github/sync-repo-settings.yaml#L5-L21 so the correct jobs are PR gates
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I meant to mention that the eventual template update PR would have a manual commit (by me) removing these configs. On the google3 side, there will only be a jump from 2 configs to 3.
Thanks, I was missing that part of the migration.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok, sync-repo-settings is a special case. The generation process can only create a new one, not update it. It will therefore be a manual commit in the eventual update PR.