Feat: Implement robust path validation and structured skip reporting#2707
Open
thiyaguk09 wants to merge 5 commits intomainfrom
Open
Feat: Implement robust path validation and structured skip reporting#2707thiyaguk09 wants to merge 5 commits intomainfrom
thiyaguk09 wants to merge 5 commits intomainfrom
Conversation
BREAKING CHANGE: downloadManyFiles now returns a DownloadManyFilesResult object instead of an array of DownloadResponse. - Implements strict blocking for absolute paths (Unix and Windows styles). - Prevents path traversal via dot-segments (../) using path.relative validation. - Blocks illegal characters and poisoned paths (e.g., Windows volume colons). - Updates internal logic to resolve paths against a safe base directory (CWD or prefix).
BREAKING CHANGE: downloadManyFiles now returns a DownloadManyFilesResult object instead of an array of DownloadResponse. - Implements strict blocking for absolute paths (Unix and Windows styles) and dot-segment traversal. - Adds DownloadManyFilesResult interface with SkipReason enums for programmatic handling of skipped files. - Ensures input-to-output parity where every file is accounted for in either 'responses' or 'skippedFiles'. - Robustly handles 'unknown' catch variables by narrowing to Error instances. - Optimizes directory creation logic within the parallel download loop.
4d80a50 to
1536b31
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Impact
Testing
Additional Information
Checklist
Fixes #2660