Skip to content
This repository was archived by the owner on Mar 13, 2018. It is now read-only.

added keyboard navigation to link tabs#51

Open
jannakha wants to merge 2 commits into
googlearchive:masterfrom
jannakha:master
Open

added keyboard navigation to link tabs#51
jannakha wants to merge 2 commits into
googlearchive:masterfrom
jannakha:master

Conversation

@jannakha

Copy link
Copy Markdown

added core-a11y-keys element to paper-tab for keyboard navigation

@googlebot

Copy link
Copy Markdown

Thanks for your pull request.

It looks like this may be your first contribution to a Google open source project, in which case you'll need to sign a Contributor License Agreement (CLA) at https://cla.developers.google.com/.

If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check the information on your CLA or see this help article on setting the email on your git commits.

Once you've done that, please reply here to let us know. If you signed the CLA as a corporation, please let us know the company's name.

@robdodson

Copy link
Copy Markdown

@morethanreal would it be possible to merge this in + mixing in Polymer.CoreFocusable?

@robdodson

Copy link
Copy Markdown

sorry, just realized I should have pinged @frankiefu

@jannakha

Copy link
Copy Markdown
Author

I signed CLA, it still shows as 'no'

@googlebot

Copy link
Copy Markdown

CLAs look good, thanks!

@robdodson

Copy link
Copy Markdown

@jannakha do you know if this works if there's an anchor inside of the paper-tab? will the listener for enter intercept it and prevent the anchor from being clicked?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants