feat: Auto-configure Plotly renderer for Colab compatibility #340
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes googlecolab#339: Interactive Plotly figures fail to render with ipywidget error. Automatically sets the Plotly renderer to 'plotly_mimetype' on first code execution per kernel session, enabling interactive Plotly charts to render correctly in VS Code when connected to a Colab runtime. Implementation: - Created plotly-config.ts module to inject Plotly config code - Modified colab-proxy-web-socket.ts to intercept execute_request messages - Uses try/except to gracefully handle cases where Plotly is not installed - Only configures on first execute_request per session (idempotent) - Follows existing pattern from drive-mount-warning.ts
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
Member
|
Just as a paper trail, ongoing discussion on the ideal approach in the linked issue #339. But thanks for the initiative here! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #339: Interactive Plotly figures fail to render with ipywidget error.
Automatically sets the Plotly renderer to 'plotly_mimetype' on first code execution per kernel session, enabling interactive Plotly charts to render correctly in VS Code when connected to a Colab runtime.
Implementation: