fix: ArrayBuffer handling in Colab proxy WebSocket #348
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hjjackyang
force-pushed
the
fix-custom-websocket
branch
from
7d5ae6d to
3e7162b
Compare
kevineger
approved these changes
Jan 6, 2026
Member
kevineger
left a comment
kevineger
left a comment
There was a problem hiding this comment.
Thanks for circling back and fixing this 🙂
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixed the ArrayBuffer handling (raised in #328) in the following way:
override sendsignature withwsand taking indataparameter asBufferLiketype.warnOnDriveMountiftypeof data === 'string'.As enhancements / refactoring, I also:
drive-mount-warning.tsintocolab-proxy-web-socket.tsto improve testability of the new behavior(s).Demo of the fixed proxy WebSocket with
drive.mountwarning and upload widget:Drive.mount.warning.after.fixing.ArrayBuffer.handling.webm