fix!: resolve issue #305 where looping could happen in typical declarative implementations - #306
Merged
Merged
Conversation
copybara-service
Bot
force-pushed
the
cl/972823989
branch
5 times, most recently
from
August 28, 2026 23:14
240825c to
3b1eeb5
Compare
copybara-service
Bot
changed the title
copybara-service
Bot
force-pushed
the
cl/972823989
branch
15 times, most recently
from
September 1, 2026 23:15
616fae4 to
73a5e6b
Compare
…ative implementations Removes a failure mode possible in React and others when handling error events. A fetch error from `<gmpx-place-overview>`, when caught, can result in the framework re-assigning the `place` property, triggering an infinite re-render loop. This change restores diff checking to the `place` property and implements regression tests. BREAKING CHANGE: If you rely on setting `elem.place = elem.place` to force a refresh, you will need to switch to a new, explicit `.refresh()` method. PiperOrigin-RevId: 974766939
copybara-service
Bot
force-pushed
the
cl/972823989
branch
from
September 1, 2026 23:22
73a5e6b to
6a33f51
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix!: resolve issue #305 where looping could happen in typical declarative implementations
Removes a failure mode possible in React and others when handling error events. A fetch error from
<gmpx-place-overview>, when caught, can result in the framework re-assigning theplaceproperty, triggering an infinite re-render loop. This change restores diff checking to theplaceproperty and implements regression tests.BREAKING CHANGE: If you rely on setting
elem.place = elem.placeto force a refresh, you will need to switch to a new, explicit.refresh()method.