Repository navigation
fix(action): expose refresh-after-release mode; fix template reconcile step - #602
Merged
Merged
Conversation
…e step Two gaps made the canonical post-release reconcile hard to adopt correctly: 1. The GitHub Action couldn't invoke refresh-after-release — it wasn't in the mode allowlist, so action users could only reach `standing-pr-update` + reconcile (that's Half 1 only, no feeder-preview refresh). Add the mode to both validModes checks and the argBuilders map (building `[refresh-after-release, --config, --project-dir]`), give it core-only outputs like backfill, and list it in the action.yml `mode` docs. 2. The shipped standing-pr.yml template's reconcile step ran `standing-pr update` without --reconcile after an immediate release — but HEAD is then a `chore: release …` commit, which the skip-pattern guard matches, so it silently no-ops. Switch it to `refresh-after-release`, which forces the reconcile bypass and also refreshes stale feeder-PR previews. Closes #601. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01K6CmYRXTZQYs4MNo6AETxT
Contributor
|
Standing release PR: #595 · v0.41.2 queued (4 packages) · open 4h 58m · ✅ ready to merge Release Preview — v0.41.1 → v0.41.2
These changes will be added to the release PR (#595) when merged: Changelogmonorepo 0.41.1 → 0.41.2
After merge — predicted release
Updated automatically by ReleaseKit |
Keep the declaration surface in sync with the runtime export so TS consumers resolving run-action.mjs via the .d.mts don't hit TS2305 (review). Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01K6CmYRXTZQYs4MNo6AETxT
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #601 — both facets of "the canonical post-release reconcile isn't cleanly adoptable."
Problem 1 — the Action couldn't invoke
refresh-after-releaseIt's a registered CLI command but wasn't in the action's
modeallowlist, souses: goosewobbler/releasekit@…users couldn't call the canonical post-release step — the closest reachable substitute (mode: standing-pr-update+reconcile: true) is only its Half 1 (no feeder-preview refresh).Fix (
scripts/run-action.mjs,action.yml):refresh-after-releaseto bothvalidModeschecks (parseInputs+runAction).buildRefreshAfterReleaseArgs→['refresh-after-release', --config, --project-dir]and wire it intoargBuilders.backfill.action.ymlmodedescription.Problem 2 — the canonical template's reconcile step silently no-ops
templates/workflows/standing-pr.yml'simmediate-releasejob ranreleasekit standing-pr updatewithout--reconcile. After the release, HEAD is achore: release …commit, which the skip-pattern guard matches, so the update returnsnoop— the "zero-staleness reconciliation" its comment promises never happens.Fix: switch that step to
releasekit refresh-after-release, whose Half 1 forces the reconcile bypass (so it runs even on the release commit) and whose Half 2 refreshes stale feeder-PR previews. Comment updated to explain why (notstanding-pr update).Validation
test/integration/action-runner.spec.ts— 2 new cases (arg builder +runActionaccepts the mode); full suite green (181).pnpm typecheck15/15;biomeclean;actionlintclean on the template (itsaction.yml"errors" are false — it's a composite-action file, not a workflow).pnpm examples:smoke:checkfails on clean main — the committed.github/workflows/examples-smoke.ymlhasactions/setup-node@v7but the generator emits@v6. It's independent of this PR (I reverted the regen to keep scope clean). Worth a one-linepnpm examples:smoke:generatefix on its own — flagging so it's not mistaken for a regression here.🤖 Generated with Claude Code
Greptile Summary
This PR exposes the canonical post-release reconciliation flow through the action and workflow template. The main changes are:
refresh-after-releaseto the action mode allowlists and argument dispatch.Confidence Score: 5/5
This looks safe to merge.
Important Files Changed
refresh-after-releaseas a supported action mode.refresh-after-release.Reviews (2): Last reviewed commit: "fix(action): declare buildRefreshAfterRe..." | Re-trigger Greptile