Repository navigation
fix(lint): keep agent worktrees out of Biome's scope - #615
Merged
Merged
Conversation
Agent worktrees under .claude/worktrees/ are full checkouts, each carrying its own root biome.jsonc. Biome refuses to run at all when it discovers a nested root config, so a single leftover worktree broke `pnpm lint` for the whole repo with an error that points at the config rather than the worktree. Gitignoring them isn't enough — vcs.useIgnoreFile is off, so Biome doesn't read .gitignore. Excluding the directory in files.includes is what actually takes it out of scope. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01FADRmu9uhtCk3StMoqwV27
Contributor
|
Standing release PR: #614 · v0.42.0 queued (4 packages) · open 26m · ✅ ready to merge Release Preview — v0.41.2 → v0.41.3
These changes will be added to the release PR (#614) when merged: Changelogmonorepo 0.41.2 → 0.41.3
After merge — predicted release
Updated automatically by ReleaseKit |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Agent worktrees under
.claude/worktrees/are full checkouts, each carrying its own rootbiome.jsonc. Biome refuses to run at all when it discovers a nested root config, so a single leftover worktree brokepnpm lintfor the whole repo:The error points at the config rather than the worktree, which makes it awkward to attribute — and it only shows up when a worktree happens to exist, so it comes and goes.
Gitignoring them isn't enough:
vcs.useIgnoreFileis off, so Biome never reads.gitignore(where.claude/worktrees/is already listed). Excluding the directory infiles.includesis what actually takes it out of scope.Verification
With a worktree present,
pnpm lintexits 1 without this change and 0 with it — checked both directions against the same worktree rather than just confirming the happy path.Repo-wide
pnpm lintis green (462 files, 29 warnings, exit 0). Those warnings are pre-existing and non-failing (13noNonNullAssertion, 6noUndeclaredEnvVars, and a scattering of others); left alone here, happy to clear them separately if you want them gone.🤖 Generated with Claude Code
https://claude.ai/code/session_01FADRmu9uhtCk3StMoqwV27
Greptile Summary
This PR prevents agent worktrees from breaking repository-wide Biome runs.
.claudedirectories from Biome file discovery.Confidence Score: 5/5
The PR appears safe to merge with no actionable defects identified.
The new exclusion prevents Biome from traversing nested agent worktrees, and the repository currently contains no tracked
.claudefiles whose lint coverage would be lost.Important Files Changed
Reviews (1): Last reviewed commit: "fix(lint): keep agent worktrees out of B..." | Re-trigger Greptile