Repository navigation
fix(publish): skip crates marked publish = false - #693
Merged
Merged
Conversation
Publish's cargo discovery took every update directory with a Cargo.toml, so a crate with `publish = false` or `publish = []` (typically a napi-rs package's crate) was sent to `cargo publish`, failing the release. The version side already skipped these; both now share isCratePublishable. Closes #692 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Contributor
|
Standing release PR: #614 · v0.42.0 queued (4 packages) · open 82d 3h 50m · ✅ ready to merge Release Preview — v0.41.2 → v0.41.3
These changes will be added to the release PR (#614) when merged: Changelogmonorepo 0.41.2 → 0.41.3
After merge — predicted release
Updated automatically by ReleaseKit |
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…able Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This was referenced Oct 22, 2026
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Publish's cargo discovery (
findCrates) took every update directory with aCargo.toml, so a crate markedpublish = falseorpublish = []was sent tocargo publish. The usual case is a napi-rs package:package.jsonplus a crate that's never meant for crates.io. WithoutCARGO_REGISTRY_TOKENthe release failed at the auth check; with one,cargo publishrefused the crate.The version side already skipped these crates. Both now share
isCratePublishablefrom@releasekit/config.This matters more with #690, which turns cargo publishing on by default for repos with no
publishblock, so it should land before or with #690.Related Issue(s)
Closes #692
Type of Change
feat— New featurefix— Bug fixdocs— Documentation changerefactor— Code refactoringtest— Adding or updating testschore— Maintenance, dependencies, toolingScope
@releasekit/version@releasekit/notes@releasekit/publish@releasekit/release@releasekit/config@releasekit/coreChecklist
pnpm lint)pnpm test)pnpm typecheck)Testing Notes
New
cargo-publish.spec.tscases: a hybrid update whoseCargo.tomlsetspublish = falseorpublish = []runs no cargo command and records no cargo output. Both fail with the skip removed. Config, version and publish suites pass (turbo run test --force).🤖 Generated with Claude Code
This PR appears safe to merge.Summary
Cargo publishing now skips crates marked
publish = falseorpublish = [].Reviews (1) · Last reviewed commit: "fix(publish): skip crates marked publish..." · Reviewed by Greptile