Repository navigation
test(notes): cut isOllamaUnreachable's tests to the three that pin its rule - #702
Merged
Merged
Conversation
…s rule The live test can't catch a predicate that calls too much an outage: it just skips. What's worth pinning is the rule a simplification would break, so keep three cases: a self-classified retryable error and a socket error in the cause chain are outages; a retryable error caused by our own code isn't. The rest restated obvious branches. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Contributor
|
Standing release PR: #614 · v0.42.0 queued (4 packages) · open 82d 6h 56m · ✅ ready to merge Release Preview — v0.41.2 → v0.41.3
These changes will be added to the release PR (#614) when merged: Changelogmonorepo 0.41.2 → 0.41.3
After merge — predicted release
Updated automatically by ReleaseKit |
This was referenced Oct 23, 2026
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
isOllamaUnreachabledecides whether the live Ollama test fails or skips. If it calls too much an outage, the live test just skips with a warning and CI stays green, so the only protection is a unit test. But seven tests was more than the rule needs.Down to one table of the three cases that pin the rule:
fetch failed: outageTypeError: not an outageThe third is the one that matters: the tempting simplification "retryable means outage" breaks it, because the provider marks any unknown error retryable. The dropped tests restated obvious branches (not an
LLMError, not retryable) or repeated the third case with a different error.Related Issue(s)
Follow-up to #618.
Type of Change
feat— New featurefix— Bug fixdocs— Documentation changerefactor— Code refactoringtest— Adding or updating testschore— Maintenance, dependencies, toolingScope
@releasekit/version@releasekit/notes@releasekit/publish@releasekit/release@releasekit/config@releasekit/coreChecklist
pnpm lint)pnpm test)pnpm typecheck)Testing Notes
Replacing the predicate with "retryable means outage" fails the third case; the other two pass, as they should.
🤖 Generated with Claude Code
This PR appears safe to merge.Summary
Replaces seven
isOllamaUnreachabletests with three table-driven cases.No actionable issues found.
Reviews (1) · Last reviewed commit: "test(notes): cut isOllamaUnreachable's t..." · Reviewed by Greptile