Repository navigation
fix(release): only create missing labels during label sync - #715
Merged
Merged
Conversation
syncLabels sent a create request for every config-implied label and relied on GitHub's "already exists" 422 to skip present ones. Octokit logs each of those requests, so every standing-PR update printed a dozen 422 lines that read like failures. List the repo's labels once (paginated), match names case-insensitively, and only request the missing ones. A 422 from a concurrent run that creates a label after the listing is still treated as existing. Applies to both standing-pr update and labels sync. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Contributor
|
Standing release PR: #614 · v0.42.0 queued (4 packages) · open 82d 22h 5m · ✅ ready to merge Release Preview — v0.41.2 → v0.41.3
These changes will be added to the release PR (#614) when merged: Changelogmonorepo 0.41.2 → 0.41.3
After merge — predicted release
Updated automatically by ReleaseKit |
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
Definitions can differ only in case (`bump:minor` and `Bump:Minor`), so a label created earlier in the loop must count as existing for the rest. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
standing-pr update(andreleasekit labels sync) sent a create request for every ReleaseKit label and relied on GitHub's 422 "already exists" to skip the ones present. Octokit logs each of those as a failed request, so every CI run printed a dozen 422 lines.Related Issue(s)
None; seen in #614's label-triggered run.
Type of Change
feat— New featurefix— Bug fixdocs— Documentation changerefactor— Code refactoringtest— Adding or updating testschore— Maintenance, dependencies, toolingScope
@releasekit/version@releasekit/notes@releasekit/publish@releasekit/release@releasekit/config@releasekit/coreChecklist
pnpm lint)pnpm test)pnpm typecheck)Testing Notes
runStandingPRUpdate,runLabelsSyncandsyncLabels); case-insensitive matching; a single listing; the 422 race; and the forge'slistLabelNamesfollowing every page.syncLabels. The race test passes on both, since the old code already tolerated it.🤖 Generated with Claude Code
The PR appears safe to merge; the previous duplicate-create issue is fixed.Summary
Label sync lists repository labels once and creates only missing labels, ignoring case.
Reviews (2) · Last reviewed commit: "fix(release): track labels created durin..." · Reviewed by Greptile