Repository navigation
fix(notes): keep a commit's breaking flag when the LLM reports it as not breaking - #718
Merged
Merged
Conversation
…not breaking The enhance-and-categorize merge took the model's `breaking` answer over the entry's own, so a `false` from the model cleared the flag a `!` commit set, and the notes lost their Breaking section. The model can now add the flag but not remove it. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Contributor
|
Standing release PR: #614 · v0.42.0 queued (4 packages) · open 82d 22h 59m · ✅ ready to merge Release Preview — v0.41.2 → v0.41.3
These changes will be added to the release PR (#614) when merged: Changelogmonorepo 0.41.2 → 0.41.3
After merge — predicted release
Updated automatically by ReleaseKit |
Merged
7 of 20 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
In LLM-enhanced notes,
enhanceAndCategorizemerged each entry'sbreakingflag asllmEntry.breaking ?? original.breaking. The response schema requires the model to answerbreaking, so afalseoverrode thetrueatype!:commit set, even though the prompt marks those entriesbreaking="true". With no breaking entries left, the renderer adds no Breaking section.#614's preview shows it: all six breaking changes in 0.42.0 (#616, #690, #694, #708, #674, #608) are listed as ordinary New or Fixed entries. Publish regenerates the notes the same way, so the release notes would miss them too.
The model can now add the flag but not remove it:
original.breaking || llmEntry.breaking === true.Related Issue(s)
None; seen in #614's release-notes preview.
Type of Change
feat— New featurefix— Bug fixdocs— Documentation changerefactor— Code refactoringtest— Adding or updating testschore— Maintenance, dependencies, toolingScope
@releasekit/version@releasekit/notes@releasekit/publish@releasekit/release@releasekit/config@releasekit/coreChecklist
pnpm lint)pnpm test)pnpm typecheck)Testing Notes
false(fails on the old merge), and the model can still mark an entry breaking.🤖 Generated with Claude Code
The PR appears safe to merge.Summary
Keeps a commit’s breaking-change flag when the model answers
false.No actionable issues found. Tests were inspected, not run.
Reviews (1) · Last reviewed commit: "fix(notes): keep a commit's breaking fla..." · Reviewed by Greptile