Skip to content

chore(biome): forbid non-null assertions - #721

Merged
goosewobbler merged 1 commit into
mainfrom
chore/no-non-null-assertion
Oct 23, 2026
Merged

goosewobbler merged 1 commit into
mainfrom
chore/no-non-null-assertion

Conversation

@goosewobbler

@goosewobbler goosewobbler commented Oct 23, 2026 •

Copy link
Copy Markdown
Owner

Biome 2 no longer includes style/noNonNullAssertion in recommended, so ! assertions slipped through. This turns the rule on as an error and replaces the 13 existing uses with narrowing.

  • src: regex captures, the first array element, and Map.get are now checked, not asserted. enhance-and-categorize uses one flatMap in place of filter + map(c => c.scopes!).
  • tests: createMockVersionOutput takes role / prerequisiteOf, so specs pass them in and don't set them afterwards through updates[0]!.

No behaviour change.

🤖 Generated with Claude Code

RetriggerView in GreptileConfidence Score: 5/5

The PR appears safe to merge.

Summary

Enables Biome’s noNonNullAssertion rule and removes existing assertions.

  • Repository code now checks values instead of asserting they exist.

Reviews (1) · Last reviewed commit: "chore(biome): forbid non-null assertions" · Reviewed by Greptile

Enable style/noNonNullAssertion as an error (Biome 2 dropped it from the
recommended preset) and replace the 13 existing assertions with narrowing.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@github-actions

Copy link
Copy Markdown
Contributor

Standing release PR: #614 · v0.42.0 queued (4 packages) · open 82d 23h 20m · ✅ ready to merge

Release Preview — v0.41.2 → v0.41.3

Note: Labels on this PR are advisory in standing-pr mode. Bumps come from conventional commits in the standing PR; override by editing labels on the standing PR itself. Add release:immediate to bypass the standing PR and release this PR directly.

These changes will be added to the release PR (#614) when merged:

Changelog

monorepo 0.41.2 → 0.41.3

Changed

  • forbid non-null assertions (biome)

All packages → 0.41.3 (sync versioning)

  • @releasekit/version
  • @releasekit/notes
  • @releasekit/publish
  • @releasekit/release

After merge — predicted release

No version escalation — this PR's changes will be included in the queued release without affecting the projected versions.

Package Standing PR This PR After merge
monorepo 0.42.0 0.41.3 0.42.0

Updated automatically by ReleaseKit

@goosewobbler
goosewobbler merged commit 175d06c into main Oct 23, 2026
32 checks passed
@goosewobbler
goosewobbler deleted the chore/no-non-null-assertion branch October 23, 2026 18:26
@github-actions github-actions Bot mentioned this pull request Oct 23, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant