Repository navigation
chore(biome): forbid non-null assertions - #721
Merged
Merged
Conversation
Enable style/noNonNullAssertion as an error (Biome 2 dropped it from the recommended preset) and replace the 13 existing assertions with narrowing. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Contributor
|
Standing release PR: #614 · v0.42.0 queued (4 packages) · open 82d 23h 20m · ✅ ready to merge Release Preview — v0.41.2 → v0.41.3
These changes will be added to the release PR (#614) when merged: Changelogmonorepo 0.41.2 → 0.41.3
After merge — predicted release
Updated automatically by ReleaseKit |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Biome 2 no longer includes
style/noNonNullAssertioninrecommended, so!assertions slipped through. This turns the rule on as an error and replaces the 13 existing uses with narrowing.Map.getare now checked, not asserted.enhance-and-categorizeuses oneflatMapin place offilter+map(c => c.scopes!).createMockVersionOutputtakesrole/prerequisiteOf, so specs pass them in and don't set them afterwards throughupdates[0]!.No behaviour change.
🤖 Generated with Claude Code


Confidence Score: 5/5
The PR appears safe to merge.Summary
Enables Biome’s
noNonNullAssertionrule and removes existing assertions.Reviews (1) · Last reviewed commit: "chore(biome): forbid non-null assertions" · Reviewed by Greptile