Repository navigation
docs(ci): warn that the Actions PR toggle also grants approvals - #758
Merged
Merged
Conversation
Co-authored-by: Cursor <cursoragent@cursor.com>
Contributor
|
Standing release PR: #730 · v0.42.1 queued (4 packages) · open 7h 37m · ✅ ready to merge Release Preview — v0.42.0 → v0.42.1
These changes will be added to the release PR (#730) when merged: Changelogmonorepo 0.42.0 → 0.42.1
After merge — predicted release
Updated automatically by ReleaseKit |
Owner
Author
|
@greptile review |
Co-authored-by: Cursor <cursoragent@cursor.com>
Owner
Author
|
@greptile review |
1 similar comment
Owner
Author
|
@greptile review |
Co-authored-by: Cursor <cursoragent@cursor.com>
Owner
Author
|
@greptile review |
…al guidance The environment advice named publish-release and immediate-release, but the ci-setup workflow and the example also publish from retry-publish. The App token must also reach refresh-after-release, which can open the standing PR. The section is shorter, the copied example workflow links to it by URL, and the template comment no longer points at a path consumers don't have. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The note sat directly above the line #756 rewrites, so the two PRs conflicted. It now has its own paragraph after the guide link. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The publish-release comment already names immediate-release, so the matching note on immediate-release repeated it. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
A branch-restricted environment rejects the publish jobs, since they run on pull_request with the ref refs/pull/N/merge. A GitHub App whose key is a repository secret can be minted by any workflow, so it doesn't close the approval gap. Code Owners review only covers paths in CODEOWNERS, so it needs a `*` rule. The section now sits under "Securing the standing PR", and the template, example and README link to it instead of restating it. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Code Owners review doesn't apply to bypass actors, and the release bot is one. A stale code-owner approval still counts after new commits unless it's dismissed, and a CODEOWNERS owner without write access is ignored. Drops the environment-reviewers suggestion: those reviewers see the same harmless-looking release, and a run waiting for approval holds the workflow's concurrency group. Links the migration guide and agents.md to the section. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
A merged PR's closed run has the branch it merged into as its ref, so an environment restricted to the default branch accepts the publish jobs it triggers. The earlier warning used the general pull_request ref, which GitHub documents an exception to for merges. Label-triggered retries may still be rejected. Also says that the template's immediate-release job needs an Actions-bot bypass on main, which voids Code Owners review for every workflow; that each standing-PR update can dismiss the standing PR's approval; and qualifies the release-branch lock, agents.md and troubleshooting.md to match. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This was referenced Oct 24, 2026
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Documents the trade-off of Allow GitHub Actions to create and approve pull requests: the same toggle lets any workflow token approve PRs, and that approval counts toward a ≥ 1-approval ruleset.
ci-setup.mdhas a new "Workflow token approvals" section under "Securing the standing PR". It explains the risk, including therelease:immediatepath, and what to add to ruleset 2:CODEOWNERS*rule naming an owner with write access, and no later pattern without one.immediate-releasejob needs one onmain, so remove it if you rely on the settings above (tracked in Standing-PR setup: bypasses for the Actions bot and workflow-wideid-token: writereach every workflow #785).closedrun has the branch it merged into as its ref, so the merge-triggered publish jobs pass. A label-triggered retry may not.docs/agents.mdanddocs/troubleshooting.mdnow say what an Actions-bot bypass opens up.examples/ci/standing-pr/standing-pr.ymland its README, the migration guide's setup step anddocs/agents.md.#653 also proposed a GitHub App token with the toggle off, which this PR leaves out on purpose. The App's key would be a repository secret, which any workflow on any branch can read, so a collaborator's workflow could mint an App token and approve their own PR. That's the same gap.
Fixes #653
Made with Cursor


Confidence Score: 5/5
The PR appears safe to merge; the previous publishing-environment omission is fixed.Summary
Documents the approval risk of GitHub Actions’ create-and-approve toggle.
Reviews (4) · Last reviewed commit: "docs(ci): require the publish environmen..." · Reviewed by Greptile