Repository navigation
fix(release): describe publish order and partial-failure recovery by mode - #762
Merged
Merged
Conversation
Co-authored-by: Cursor <cursoragent@cursor.com>
Owner
Author
|
@greptile review |
Contributor
|
Standing release PR: #730 · v0.42.1 queued (4 packages) · open 7h 9m · ✅ ready to merge Release Preview — v0.42.0 → v0.42.1
These changes will be added to the release PR (#730) when merged: Changelogmonorepo 0.42.0 → 0.42.1
After merge — predicted release
Updated automatically by ReleaseKit |
Co-authored-by: Cursor <cursoragent@cursor.com>
Owner
Author
|
@greptile review |
- The state line no longer gives instructions. It told a direct failure to re-run `publish` while the recovery section said "Re-run failed jobs", and it repeated the tag warning the safe-retry note already gives. - The direct and dispatch recovery lines no longer say nothing was pushed: after a push-stage failure the branch may be on the remote. - architecture.md gives per-package mode's push order as branch, then tag, which #751 makes the code do, and folds the duplicate idempotency section into the one above it. - The supersede-warning test fixture matches the rendered text. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This was referenced Oct 23, 2026
Closed
A failed per-package direct release is rolled forward, and re-running it fails, so the report shouldn't follow that advice with "Retrying is safe". Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This was referenced Oct 24, 2026
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Docs disagreed with each other, and with the pipeline, about when commits and tags are pushed and how to recover.
docs/architecture.mdis now the single description: batch mode pushes only after every publish succeeds; per-package mode pushes the branch, then that package's tag, as each package succeeds; standing-PR mode already has the commit onmain.AGENTS.md, and the release-retry workflow link to that and no longer say to delete a tag whose version was published.Fixes #740.
Closes #735: #765 fixed items 1 and 2, and this settles item 3 the documented way, by rolling a per-package direct failure forward. Its remaining gaps moved to #774.
Known gap, out of scope here: when a direct release's branch push lands but a tag push fails, the report still recommends "Re-run failed jobs", which can't succeed. Tracked in #774.
Made with Cursor
The PR appears safe to merge, with non-blocking corrections needed in its recovery guidance.
Summary
The PR makes
docs/architecture.mdthe shared description of publish order and recovery.Diagram
%%{init: {'theme': 'neutral'}}%% flowchart TD A[Prepare files and local release tags] --> B{Publish mode} B -->|Batch| C[Publish all packages and verify] C --> D[Push branch, then tags] B -->|Per-package| E[Publish and verify one package] E --> F[Push its tag, then branch] F --> G{More packages?} G -->|Yes| E G -->|No| H[Finish remaining pushes] D --> I[Create GitHub Releases] H --> I J[Standing PR already merged] -. Skip branch pushes .-> D J -. Skip branch pushes .-> FReviews (1) · Last reviewed commit: "docs: describe publish order and partial..." · Reviewed by Greptile