Repository navigation
fix(version): load the config from a relative --project-dir - #763
Closed
goosewobbler wants to merge 1 commit into
Closed
goosewobbler wants to merge 1 commit into
goosewobbler wants to merge 1 commit into
Conversation
The version command changed into --project-dir and then loaded the config with the same relative path, so it looked in <dir>/<dir>, found nothing and ran with the defaults. Resolve --project-dir once, before the chdir, and use it for both. The other commands that take --project-dir never chdir. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Contributor
|
Standing release PR: #730 · v0.42.1 queued (4 packages) · open 2h 48m · ✅ ready to merge Release Preview — v0.42.0 → v0.42.1
These changes will be added to the release PR (#730) when merged: Changelogmonorepo 0.42.0 → 0.42.1
After merge — predicted release
Updated automatically by ReleaseKit |
Owner
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
releasekit version --project-dir <relative>changed into the directory, then loaded the config with the same relative path. It read<dir>/<dir>/releasekit.config.json, found nothing and silently ran with the defaults. An absolute path worked.--project-diris resolved once, before the chdir. The same absolute path is used for the chdir and the config load.--outputstill resolves against the invocation directory.notesandpublishhave no--project-dir.releasesubcommands take it but never chdir, so they already resolve it once.Related Issue(s)
Fixes #698
Type of Change
feat— New featurefix— Bug fixdocs— Documentation changerefactor— Code refactoringtest— Adding or updating testschore— Maintenance, dependencies, toolingScope
@releasekit/version@releasekit/notes@releasekit/publish@releasekit/release@releasekit/config@releasekit/coreChecklist
pnpm lint)pnpm test)pnpm typecheck)Testing Notes
--project-dir app, and checks that it appliesapp's config. WithversionPrefix: "release-"the tag isrelease-0.2.0. Without the fix it gets the defaultv0.2.0.pnpm testand the@releasekit/versiontest:integrationsuite all pass.🤖 Generated with Claude Code