Repository navigation
fix(release): report a merged standing PR as changed - #764
Closed
goosewobbler wants to merge 1 commit into
Closed
goosewobbler wants to merge 1 commit into
goosewobbler wants to merge 1 commit into
Conversation
`standing-pr merge` without `--publish` returned null after merging, so
`--json` reported `changed: false`, the same as finding no open standing
PR. It now returns `{ action: 'merged' | 'noop', prNumber, prUrl,
releaseOutput? }`, and `changed` is true whenever the merge happened.
With `--publish`, the publish result moves to `data.releaseOutput`.
A missing GitHub context or token now throws, as `standing-pr publish`
does, instead of logging an error and exiting 0.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Contributor
|
Standing release PR: #730 · v0.42.1 queued (4 packages) · open 2h 49m · ✅ ready to merge Release Preview — v0.42.0 → v0.42.1
These changes will be added to the release PR (#730) when merged: Changelogmonorepo 0.42.0 → 0.42.1
After merge — predicted release
Updated automatically by ReleaseKit |
Owner
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
standing-pr mergewithout--publishreturnednullafter a successful merge. So--jsonreportedchanged: false, the same as finding no open standing PR. A missing GitHub context or token also returnednull, so a misconfiguration exited 0.{ action: 'merged' | 'noop', prNumber, prUrl, releaseOutput? }, following theactionfield ofstanding-pr update.changedis true whenever the merge happened, whether or not it published.--publish, the publish result moves fromdatatodata.releaseOutput.data: { action: 'noop' }rather thannull.standing-pr publishdoes (GENERAL_ERROR, exit 1).Unchanged: if
--publishmerges and the publish then fails, the error envelope still reportschanged: false.Related Issue(s)
Fixes #724
Type of Change
feat— New featurefix— Bug fixdocs— Documentation changerefactor— Code refactoringtest— Adding or updating testschore— Maintenance, dependencies, toolingScope
@releasekit/version@releasekit/notes@releasekit/publish@releasekit/release@releasekit/config@releasekit/coreChecklist
pnpm lint)pnpm test)pnpm typecheck)Testing Notes
standing-pr merge --jsonand checking the envelope and the exit code:--publishreportschanged: truewith the merged PR.changed: falsewith{ action: 'noop' }.GENERAL_ERRORand exit 1, and merges nothing.--publishassertion.pnpm testpass.🤖 Generated with Claude Code