Fix: Resolve cyclic loop, correct syntax, and add ISO helper functions - #3
Open
ankurgupta10 wants to merge 1 commit into
Open
Fix: Resolve cyclic loop, correct syntax, and add ISO helper functions#3ankurgupta10 wants to merge 1 commit into
ankurgupta10 wants to merge 1 commit into
Conversation
1 Math.floor - lowercase correction
2 Add 'this' operator
3 Add couple of needed functions
get ISOCode()
and
static FindCountryByISOCode(code)
4 Commenting below line - causing cyclic loop
// console.log('Timezone offset x:', A[0])
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR includes a few minor corrections and feature additions:
Math.floor.thiskeyword to correctly reference the object.get ISOCode()static FindCountryByISOCode(code)// console.log('Timezone offset x:', A[0])) that was causing a cyclic loop.