Skip to content

ci: use Web normal for SPX module smoke - #332

Merged
joeykchen merged 1 commit into
goplus:spx4.4.1from
joeykchen:ci/web-normal-spx-module-smoke
Aug 12, 2026
Merged

ci: use Web normal for SPX module smoke#332
joeykchen merged 1 commit into
goplus:spx4.4.1from
joeykchen:ci/web-normal-spx-module-smoke

Conversation

@joeykchen

Copy link
Copy Markdown

No description provided.

@fennoai fennoai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review summary

Converts the web-worker-smoke job into a web-normal-smoke job: switches the SCons build from a threaded template (threads=yes proxy_to_pthread=yes) to a non-threaded one (threads=no), and updates the job id, display names, cache-scope, and verified archive filename accordingly.

No issues found. The change is correct and internally consistent:

  • The verified archive godot.web.template_release.wasm32.nothreads.zip matches the threads=no build output — SConstruct appends .nothreads to the suffix when threads are disabled.
  • Dropping proxy_to_pthread=yes is correct: with threads=no, platform/web/detect.py force-disables proxy_to_pthread anyway.
  • The rename is applied consistently (job id, names, cache-scope), no stale web-worker-smoke references remain in the repo, and the caller (release_builds.yml) invokes this workflow by file path rather than internal job name, so the rename doesn't break it.
  • No security or permissions concerns; contents: read and static build flags are unchanged in substance.

Optional (non-blocking) note: the verified archive filename on the last step is a hardcoded literal implicitly coupled to the build flags — if flags change again it must be kept in sync manually. This matches the pre-existing pattern and is not a regression.

@joeykchen
joeykchen merged commit ab8a457 into goplus:spx4.4.1 Aug 12, 2026
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants