ci: use Web normal for SPX module smoke - #332
Merged
joeykchen merged 1 commit intoAug 12, 2026
Merged
Conversation
There was a problem hiding this comment.
Review summary
Converts the web-worker-smoke job into a web-normal-smoke job: switches the SCons build from a threaded template (threads=yes proxy_to_pthread=yes) to a non-threaded one (threads=no), and updates the job id, display names, cache-scope, and verified archive filename accordingly.
No issues found. The change is correct and internally consistent:
- The verified archive
godot.web.template_release.wasm32.nothreads.zipmatches thethreads=nobuild output —SConstructappends.nothreadsto the suffix when threads are disabled. - Dropping
proxy_to_pthread=yesis correct: withthreads=no,platform/web/detect.pyforce-disablesproxy_to_pthreadanyway. - The rename is applied consistently (job id, names,
cache-scope), no staleweb-worker-smokereferences remain in the repo, and the caller (release_builds.yml) invokes this workflow by file path rather than internal job name, so the rename doesn't break it. - No security or permissions concerns;
contents: readand static build flags are unchanged in substance.
Optional (non-blocking) note: the verified archive filename on the last step is a hardcoded literal implicitly coupled to the build flags — if flags change again it must be kept in sync manually. This matches the pre-existing pattern and is not a regression.
nighca
approved these changes
Aug 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.