Skip to content

test: restore concurrent demo execution#662

Open
luoliwoshang wants to merge 1 commit intogoplus:mainfrom
luoliwoshang:codex/demo-concurrency
Open

test: restore concurrent demo execution#662
luoliwoshang wants to merge 1 commit intogoplus:mainfrom
luoliwoshang:codex/demo-concurrency

Conversation

@luoliwoshang
Copy link
Member

@luoliwoshang luoliwoshang commented Feb 26, 2026

Summary

  • restore RunAllGenPkgDemos to concurrent demo execution
  • collect failures via failedDemosCh and report aggregated failures

Notes

  • this branch currently only carries the requested restoration commit

@gemini-code-assist
Copy link
Contributor

Note

Gemini is unable to generate a summary for this pull request due to the file types involved not being currently supported.

@xgopilot
Copy link
Contributor

xgopilot bot commented Feb 26, 2026

Review Summary

This PR appears to have no code changes. The diff is empty - the PR commit (78051e7) contains no file modifications compared to its parent commit.

Observations:

  • The PR description mentions restoring RunAllGenPkgDemos to concurrent demo execution
  • However, the current main branch already has concurrent execution implemented via goroutines (see cmd/llcppgtest/demo/demo.go:234-244)
  • The branch is 14 commits behind main and 1 commit ahead, but that commit contains no changes

Recommendation: Please verify the intended changes were committed. It appears the commit may have been created without staging the intended modifications, or the feature was already merged to main via a different PR.

@codecov
Copy link

codecov bot commented Feb 26, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 84.06%. Comparing base (2f8e292) to head (78051e7).
⚠️ Report is 14 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #662      +/-   ##
==========================================
- Coverage   84.74%   84.06%   -0.69%     
==========================================
  Files          27       28       +1     
  Lines        2314     2773     +459     
==========================================
+ Hits         1961     2331     +370     
- Misses        310      392      +82     
- Partials       43       50       +7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant