go 1.25 - #163
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #163 +/- ##
=======================================
Coverage 81.34% 81.34%
=======================================
Files 10 10
Lines 906 906
=======================================
Hits 737 737
Misses 150 150
Partials 19 19 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Review Summary
This PR bumps the toolchain and dependencies:
go.mod:go 1.24→go 1.25.0,github.com/qiniu/xv1.18.0→v1.18.3,golang.org/x/modv0.20.0→v0.40.0.github/workflows/go.yml: drops1.24.xfrom the CI matrix (now[1.25.x, 1.26.x])go.sum: corresponding hash updates
Verification performed locally on the pinned range: go build ./..., go vet ./..., and go mod verify all pass; go.sum checksums match the official Go checksum database (sum.golang.org).
The three changes are internally consistent and mutually reinforcing — golang.org/x/mod v0.40.0 declares go 1.25.0 in its own module, which forces this module's floor up to 1.25.0, and dropping the 1.24.x runner is the correct consequence (a 1.24 runner could no longer build against a go 1.25.0 directive).
Note (non-blocking)
- Raised minimum Go version for downstream consumers. Bumping the
godirective to1.25.0means any consumer ofgithub.com/goplus/modnow needs a Go 1.25+ toolchain. This is a compatibility-affecting change (beyond a routine dependency refresh) — fine if intentional, just worth being explicit about since it's driven by thex/modupgrade.
No blocking issues found. Security (supply-chain hashes verified), performance, and documentation checks surfaced nothing actionable.
No description provided.