Skip to content

go 1.25 - #163

Merged
xushiwei merged 2 commits into
goplus:mainfrom
xushiwei:q
Aug 16, 2026
Merged

go 1.25#163
xushiwei merged 2 commits into
goplus:mainfrom
xushiwei:q

Conversation

@xushiwei

Copy link
Copy Markdown
Member

No description provided.

@xushiwei
xushiwei merged commit f4300a7 into goplus:main Aug 16, 2026
6 checks passed
@codecov

codecov Bot commented Aug 16, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 81.34%. Comparing base (a9c6a26) to head (9f50c4c).
⚠️ Report is 3 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #163   +/-   ##
=======================================
  Coverage   81.34%   81.34%           
=======================================
  Files          10       10           
  Lines         906      906           
=======================================
  Hits          737      737           
  Misses        150      150           
  Partials       19       19           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@fennoai fennoai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review Summary

This PR bumps the toolchain and dependencies:

  • go.mod: go 1.24go 1.25.0, github.com/qiniu/x v1.18.0v1.18.3, golang.org/x/mod v0.20.0v0.40.0
  • .github/workflows/go.yml: drops 1.24.x from the CI matrix (now [1.25.x, 1.26.x])
  • go.sum: corresponding hash updates

Verification performed locally on the pinned range: go build ./..., go vet ./..., and go mod verify all pass; go.sum checksums match the official Go checksum database (sum.golang.org).

The three changes are internally consistent and mutually reinforcing — golang.org/x/mod v0.40.0 declares go 1.25.0 in its own module, which forces this module's floor up to 1.25.0, and dropping the 1.24.x runner is the correct consequence (a 1.24 runner could no longer build against a go 1.25.0 directive).

Note (non-blocking)

  • Raised minimum Go version for downstream consumers. Bumping the go directive to 1.25.0 means any consumer of github.com/goplus/mod now needs a Go 1.25+ toolchain. This is a compatibility-affecting change (beyond a routine dependency refresh) — fine if intentional, just worth being explicit about since it's driven by the x/mod upgrade.

No blocking issues found. Security (supply-chain hashes verified), performance, and documentation checks surfaced nothing actionable.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant