feat(process): add reusable child supervisor - #1755
Merged
Merged
Conversation
joeykchen
force-pushed
the
refactor/process-supervisor
branch
from
August 21, 2026 04:20
f9ddca4 to
f191b05
Compare
joeykchen
marked this pull request as ready for review
August 21, 2026 04:24
Contributor
There was a problem hiding this comment.
Reviewed the complete fixed diff for the reusable process supervisor, including Unix process-group shutdown, cancellation/status handling, Windows job-object lifecycle, module changes, and tests. I found no reportable correctness, reliability, security, or compatibility regression introduced by this PR.
Verification completed: go test ./internal/processsupervisor, go test -race ./internal/processsupervisor, go vet ./internal/processsupervisor, GOOS=windows GOARCH=amd64 go test -c ./internal/processsupervisor, and go test ./....
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Extracts the driver-independent child-process lifecycle layer from #1753.
exec.Cmdwithout changing the caller working directory, environment, or process-wide signal subscriptions.This PR has no Project Driver, runtime bundle, cache, XGo, Mod, or release dependency.
Verification
Follow-up
After merge, #1753 will rebase onto
devand remove this package from its diff. Runtime archive verification and transactional cache extraction are being prepared separately.