feat(runtimebundle): verify portable runtime archives - #1756
Merged
joeykchen merged 1 commit intoAug 21, 2026
Conversation
joeykchen
marked this pull request as ready for review
August 21, 2026 04:24
Contributor
There was a problem hiding this comment.
The manifest strictness, archive bounds, ZIP offset checks, content hashing, extraction confinement, and cross-platform build paths were reviewed. The Windows permission seam is not connected to extraction, so the current-user-only DACL contract is not enforced for the extraction root and regular files. Focused tests, race tests, vet, GOOS=windows GOARCH=amd64 go test -c, go mod tidy -diff, and go test ./... passed.
joeykchen
force-pushed
the
refactor/runtime-bundle-verification
branch
from
August 21, 2026 04:31
0a8752e to
0bc5eae
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Extracts the Driver-independent archive identity and verification foundation from #1753.
os.Roothandles and fail closed on source mutation, symlink traversal, or destination replacement.The archive layer no longer depends on cache implementation details: digest helpers and reserved metadata names live with bundle verification. Redundant compatibility aliases and mutable global default limits were removed.
This PR contains no cache, download/acquire, Project Driver, launcher, release, or process-supervision code.
Verification
Follow-up
After merge, the transactional cache/lock layer can build on this package in a separate PR, followed by acquire/download. #1753 will rebase and remove each merged foundation from its diff.