refactor(pack): harden project staging and export paths - #1763
Merged
Conversation
Contributor
There was a problem hiding this comment.
Reviewed the fixed 7b73af9d73edfeda5a5ee7c33e57e0b78f29ccf9...de056654e58bb71ef608ab7a14bcff3db2685860 diff across pack input validation, deterministic output publication, external asset resolution, and export staging. I found no PR-introduced correctness, security, or compatibility issue that meets the review threshold.
Verification: go test -race ./cmd/spx/..., go vet ./cmd/spx/..., and git diff --check pass. The broader go test ./... run is otherwise green but retains an unrelated failure in internal/projectpolicy/TestPortableConfigSnapshotRejectsIdentityAndContentDrift.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Validation
go test -race ./cmd/spx/...go test ./...go vet ./...pure_enginecompile for pack and commandgo mod tidy -diffgit diff --check