feat(ispxnative): load pinned portable project config - #1764
Merged
Conversation
Contributor
There was a problem hiding this comment.
Reviewed the fixed range 7b73af9d73edfeda5a5ee7c33e57e0b78f29ccf9...2a0efad9de3828db93d1cfb6f13c1268a38bacdd} across the runtime environment propagation, pinned config loading, and overlay filesystem units. The pinned snapshot and overlay behavior are covered by focused tests; go test -race ./cmd/ispxnative ./internal/interpruntime and git diff --check pass. One regression in forwarding the new portable-config contract is called out inline.
Additional findings
internal/interpruntime/roots.go:166: [P1] Preserve portable config variables when building child environments:rootEnvKeynow classifiesSPX_PORTABLE_CONFIG_DIRandSPX_PORTABLE_CONFIG_IDENTITYas root variables, so this loop removes both frombase, but the return value only re-adds the three legacy roots. Any caller that usesRoots.Environmentto launchispxnativetherefore drops the pinned config directory and identity; the child sees no portable overlay and falls back to its project.config, defeating the new identity-bound behavior (or silently losing the portable config when the project copy differs). Preserve the validated pair when present, or filter only the three legacy keys here.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Validation
go test -race ./cmd/ispxnative ./internal/interpruntimego test ./...go vet ./...go test -tags pure_engine ./cmd/ispxnative ./internal/interpruntimepure_enginecompilego mod tidy -diffgit diff --check