feat(spx): add driver-independent buildlauncher - #1767
Conversation
There was a problem hiding this comment.
Reviewed the complete fixed diff for command dispatch, module-graph provenance, project metadata, output staging, platform-specific replacement, and the added tests/docs. The buildlauncher path is generally well-contained and the focused Linux package tests pass. One compatibility issue should be addressed before merging.
Validation: go test ./cmd/spx/internal/command ./internal/launchpack passed. A Windows cross-build was attempted but remains blocked by existing non-Windows package symbols in internal/gdengine.
| cmd.Args.Mode = f.String("mode", "none", "mode: none, worker, minigame") | ||
| cmd.Args.Movie = f.Bool("movie", false, "record movie mode") | ||
| cmd.Args.Verbose = f.Bool("v", false, "print verbose information") | ||
| cmd.Args.Output = f.String("o", "", "launcher output path (buildlauncher)") |
There was a problem hiding this comment.
[P2] Scope the launcher output flag to buildlauncher
Registering -o in the shared flag set makes it valid for every command, but only buildlauncher consumes Args.Output; the legacy command paths ignore it (and ExtraArgs.String does not forward it). This changes previously rejected invocations such as spx run -o out into silently successful runs that discard the user's requested output, which can hide a typo or produce an unexpected artifact. Keep this flag scoped to buildlauncher, or explicitly reject it for the other command paths.
f8b3b3f to
2cec025
Compare
Summary
Built on the launchpack service merged in #1766.
Verification