fix(release): track local runtime metadata - #1768
Merged
joeykchen merged 1 commit intoAug 21, 2026
Merged
Conversation
![fennoai[bot]](https://avatars.githubusercontent.com/in/1924301?s=60&v=4){kind=small}
| RUNTIME_LOCK_SNAPSHOTS := $(wildcard internal/release/runtime_locks/*.json) | ||
| BUILDCTL_SOURCES := go.mod $(OPTIONAL_GO_SUM) $(MACOS_GO_TOOLCHAIN) internal/release/runtime.lock.json $(RUNTIME_LOCK_SNAPSHOTS) $(shell find cmd internal -type f -name '*.go' ! -name '*_test.go' | LC_ALL=C sort) | ||
| RUNTIME_MANIFEST_PINS := $(wildcard internal/release/runtime_manifest_pins/*.json) | ||
| BUILDCTL_SOURCES := go.mod $(OPTIONAL_GO_SUM) $(MACOS_GO_TOOLCHAIN) internal/release/runtime.lock.json $(RUNTIME_LOCK_SNAPSHOTS) $(RUNTIME_MANIFEST_PINS) $(shell find cmd internal -type f -name '*.go' ! -name '*_test.go' | LC_ALL=C sort) |
Contributor
There was a problem hiding this comment.
[P2] Track pins in the shell buildctl freshness check
internal/cmd/buildctl/buildctl.sh is another path that reuses .bin/buildctl, but its find expression still only considers Go files, runtime.lock.json, and runtime_locks/*.json. When a runtime_manifest_pins/*.json file changes, invoking build_docker.sh or build_bydocker.sh through this wrapper keeps the old binary and therefore the old embedded pin data, even though the Makefile path rebuilds correctly. Please add the manifest-pin glob to that freshness check as well so all cached buildctl entry points invalidate consistently.
joeykchen
force-pushed
the
fix/buildctl-runtime-manifest-pins
branch
from
August 21, 2026 07:56
3d60caf to
9204af4
Compare
joeykchen
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This keeps local runtime metadata out of commits and rebuilds buildctl when embedded pins change.
Verification