Skip to content

fix(launchpack): fall back to local dev runtime - #1773

Merged
joeykchen merged 1 commit into
goplus:devfrom
joeykchen:fix/dev-runtime-fallbacks
Aug 21, 2026
Merged

fix(launchpack): fall back to local dev runtime#1773
joeykchen merged 1 commit into
goplus:devfrom
joeykchen:fix/dev-runtime-fallbacks

Conversation

@joeykchen

Copy link
Copy Markdown
Contributor

Summary

  • keep explicit local inputs fail-closed, then prefer verified release cache/download
  • for SPX source checkouts, fall back to exact-version Engine/PCK from the first GOPATH/bin when a runtime is unpublished or acquisition fails
  • validate regular non-symlink files, preserve strict explicit-manifest checks, avoid source-tree writes and implicit Godot builds
  • document offline and make dev behavior

PR #1772 is already merged; this branch is based on that runnative environment fix.

Verification

  • GOWORK=off go test ./...
  • GOWORK=off go vet ./...
  • GOWORK=off go test -race ./internal/release ./internal/launchpack ./cmd/spx/internal/command
  • tutorial/05-Animation: buildlauncher and 20-second headless launcher smoke
  • Coding-Course-49: runnative -headless ran 20 seconds without the SPX_PROJECT_DIR error

@fennoai fennoai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review Conclusion

Reviewed the complete fixed diff for runtime acquisition ordering, explicit local input fail-closed behavior, source-checkout fallback, manifest validation, file integrity checks, and cache/materialization flows. I found no actionable correctness, security, or compatibility regression introduced by this PR.

Verification completed with GOWORK=off go test ./internal/launchpack ./internal/release ./cmd/spx/internal/command and the corresponding -race test run; both passed.

@joeykchen
joeykchen merged commit 5f064ca into goplus:dev Aug 21, 2026
11 checks passed
@joeykchen
joeykchen deleted the fix/dev-runtime-fallbacks branch August 24, 2026 01:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant