feat(classfile): add resource schema reader - #2726
Draft
aofei wants to merge 2 commits into
Draft
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2726 +/- ##
==========================================
+ Coverage 94.27% 94.32% +0.05%
==========================================
Files 32 32
Lines 10576 10637 +61
==========================================
+ Hits 9970 10033 +63
+ Misses 431 429 -2
Partials 175 175 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request introduces a resource schema loading system for XGo classfiles, enabling the discovery and validation of resource kinds and API scope bindings through source-level directives. It includes the implementation of a schema loader, comprehensive tests, and a new specification document. The review feedback focuses on enhancing diagnostic quality by tracking the source positions of resource declarations, which would allow for more precise error messages when encountering duplicate types or undeclared parent kinds.
aofei
force-pushed
the
classfile-resource-schema-reader
branch
7 times, most recently
from
April 15, 2026 09:40
4d407c5 to
c1db598
Compare
aofei
force-pushed
the
classfile-resource-schema-reader
branch
2 times, most recently
from
July 31, 2026 12:29
956dd27 to
e352268
Compare
Define framework resource kinds, pack-document discovery, typed scope bindings, and static tool semantics for classfile resources. Specify active project groups and flat project lowering, including shared project types, fragment ordering, field initialization, and callback assembly. Clarify pack-document merging and DQL query fragments relative to implicit discovery roots. Fixes goplus#2704 Updates goplus#2719 Updates goplus#2802 Signed-off-by: Aofei Sheng <aofei@aofeisheng.com>
aofei
force-pushed
the
classfile-resource-schema-reader
branch
2 times, most recently
from
August 6, 2026 01:11
b3c2bf3 to
58c2bf9
Compare
Add `cl/outline/classfile` to load resource schemas declared by typed framework packages. Collect resource kinds, discovery query fragments, handle-bearing types, and API scope bindings from Go and XGo source. Make outline loading read Go source expressions reliably and defer generic constraint validation until recursive types are complete. This keeps real framework packages working with Go 1.24 without accepting invalid type arguments. Updates goplus#2704 Signed-off-by: Aofei Sheng <aofei@aofeisheng.com>
aofei
force-pushed
the
classfile-resource-schema-reader
branch
from
August 6, 2026 02:59
58c2bf9 to
630f287
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add
cl/outline/classfileto load resource schemas declared by typed framework packages.Collect resource kinds, discovery query fragments, handle-bearing types, and API scope bindings from Go and XGo source.
Make outline loading read Go source expressions reliably and defer generic constraint validation until recursive types are complete. This keeps real framework packages working with Go 1.24 without accepting invalid type arguments.
Updates #2704