Skip to content

Fix stix package syntax errors, move release docs to the contribution guide - #48

Merged
gormaniac merged 1 commit into
mainfrom
claude/ecstatic-carson-rndfji
Nov 1, 2026
Merged

gormaniac merged 1 commit into
mainfrom
claude/ecstatic-carson-rndfji

Conversation

@gormaniac

Copy link
Copy Markdown
Owner

stix package

The slib.stix package had Storm syntax errors, so it couldn't load into a Cortex. Synapse's linter reported them as E001 at slib.stix.ingest.storm:16 and slib.stix.lib.storm:17.

  • Quote the form and node data names compared or used as strings ("it:sec:stix:bundle", "stix:bundle", "stix:object"), fix the unbalanced parens in ingest(), and parenthesize if ($config = $lib.null).
  • Replace the $lib.debug(...) calls with if $lib.debug { $lib.print(...) }. $lib.debug is a boolean, so calling it raised an error on the HTTP error path.
  • Drop the unnecessary parens around {} inside the command's expressions, so the package lints clean.
  • Add tests/pkgs/stix/: one test loads the package, imports slib.stix.lib, and checks the command exists, and one checks that --url and --obj together raise the expected error. Both fail with the original BadSyntax on main and pass with this change.
  • Patch bump: stix 0.1.1 → 0.1.2.

This makes the package load; it doesn't make it work end to end. The package is still marked "Work In Progress!", for two reasons:

  • pullConfig() fetches data/stix_import_conf.json from this repo, and that file doesn't exist.
  • The command's main body only runs per inbound node, so slib.stix.ingest --url ... or --obj ... with no inbound nodes ingests nothing.

Docs

  • Removed the README's "Releasing" section. doc/contributing.md already covered all of it except the first step, adding CHANGELOG.md entries under ## Unreleased as changes land. That's now step 1 of its Releases list.
  • Fixed the README's documentation link (docs.gormo.com → docs.gormo.co, the domain pyproject.toml and the docs use).

Testing

  • pytest tests: 32 passed. The deprecation check from tests/conftest.py is on.
  • python -m synapse.tools.storm.lint src/pkgs/stix: all checks pass.

Generated by Claude Code

…n guide

- Fix the stix package's Storm syntax errors so it loads: quote form and node
  data names used as strings, and parenthesize the $config comparison.
- Replace $lib.debug(...) calls with `if $lib.debug { $lib.print(...) }`,
  $lib.debug is a boolean.
- Add tests that load the package and check --url/--obj validation.
- Remove the README's Releasing section, the contribution guide already covers
  it; add its CHANGELOG step there. Fix the README's docs link.
- Patch bump the stix package.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01KBLBzjs3FWt5tMeTsVjC79
@gormaniac
gormaniac merged commit 5ced18a into main Nov 1, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants