Repository navigation
Fix stix package syntax errors, move release docs to the contribution guide - #48
Merged
Merged
Conversation
…n guide
- Fix the stix package's Storm syntax errors so it loads: quote form and node
data names used as strings, and parenthesize the $config comparison.
- Replace $lib.debug(...) calls with `if $lib.debug { $lib.print(...) }`,
$lib.debug is a boolean.
- Add tests that load the package and check --url/--obj validation.
- Remove the README's Releasing section, the contribution guide already covers
it; add its CHANGELOG step there. Fix the README's docs link.
- Patch bump the stix package.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01KBLBzjs3FWt5tMeTsVjC79
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
stix package
The
slib.stixpackage had Storm syntax errors, so it couldn't load into a Cortex. Synapse's linter reported them asE001atslib.stix.ingest.storm:16andslib.stix.lib.storm:17."it:sec:stix:bundle","stix:bundle","stix:object"), fix the unbalanced parens iningest(), and parenthesizeif ($config = $lib.null).$lib.debug(...)calls withif $lib.debug { $lib.print(...) }.$lib.debugis a boolean, so calling it raised an error on the HTTP error path.{}inside the command's expressions, so the package lints clean.tests/pkgs/stix/: one test loads the package, importsslib.stix.lib, and checks the command exists, and one checks that--urland--objtogether raise the expected error. Both fail with the originalBadSyntaxonmainand pass with this change.0.1.1→0.1.2.This makes the package load; it doesn't make it work end to end. The package is still marked "Work In Progress!", for two reasons:
pullConfig()fetchesdata/stix_import_conf.jsonfrom this repo, and that file doesn't exist.slib.stix.ingest --url ...or--obj ...with no inbound nodes ingests nothing.Docs
doc/contributing.mdalready covered all of it except the first step, addingCHANGELOG.mdentries under## Unreleasedas changes land. That's now step 1 of its Releases list.docs.gormo.com→docs.gormo.co, the domainpyproject.tomland the docs use).Testing
pytest tests: 32 passed. The deprecation check fromtests/conftest.pyis on.python -m synapse.tools.storm.lint src/pkgs/stix: all checks pass.Generated by Claude Code