pft: Enable multi-map support#1
Open
punitagrawal wants to merge 1 commit into
Open
Conversation
The code to create multiple memory regions (one per thread) is available but commented out. The feature is useful to evaluate the benefits of per-VMA locks[0] patchset which breaks the mmap_lock covering the entire address space into locks per region of memory. As the code was able to create multiple regions (verified via /proc/$$/maps), enable it for wider usage. Signed-off-by: Punit Agrawal <punit.agrawal@bytedance.com>
Author
|
I am not sure the problems that caused the feature to be disabled but it seemed to work correctly in local tests. If the situation has changed, it'd be good to get this enabled. I can try to address the issues if there are any pointers. Once merged here, I would like to add a workload in mm-tests enabling this as well. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The code to create multiple memory regions (one per thread) is available but commented out. The feature is useful to evaluate the benefits of per-VMA locks[0] patchset which breaks the mmap_lock covering the entire address space into locks per region of memory.
As the code was able to create multiple regions (verified via /proc/$$/maps), enable it for wider usage.