Skip to content

Fix modal not showing on delete issue#226

Merged
stefan-gorules merged 2 commits into
gorules:masterfrom
d-sooter:master
Mar 11, 2026
Merged

Fix modal not showing on delete issue#226
stefan-gorules merged 2 commits into
gorules:masterfrom
d-sooter:master

Conversation

@d-sooter

@d-sooter d-sooter commented Feb 3, 2026

Copy link
Copy Markdown
Contributor

Delete confirmation is not showing up on newer react and nextjs version. Antd recomments using App.modal to solve that in newer versions. Tested with Storybook and React 19 plus nextjs 16

@d-sooter

Copy link
Copy Markdown
Contributor Author

@stefan-gorules are changes like these welcome? or would we need larger general changes for react 19. there seems to be some issues and im happy to help resolve them but not sure how we can move forward. I could fork it and make the changes there we need but i would be very happy if we can give back and help improve the core. If there is anything we can do to get this moving let us know. Also things like migrating to the newer react-flow version might be interesting and i am happy to help with that .

@stefan-gorules

Copy link
Copy Markdown
Contributor

Hi @d-sooter, thanks for the PR. Internally we had a discussion regarding antd and the most likely outcome is that we will be migrating over to mantine within the next 3 months. Ant Design has went through a lot of changes and it's making it more and more difficult to keep up to date with each React upgrade.

Changes like these are welcome - if you can rebase to resolve theme.tsx conflict, we can merge this one. Just giving a heads up regarding switching over to mantine. Curious to hear your thoughts as well regarding mantine. Thanks!

@d-sooter

Copy link
Copy Markdown
Contributor Author

@stefan-gorules I like Mantine a lot its a solid library and easy to use. Let me know if you guys need help to port it once you decde to pull the trigger on it. I resolved the conflicts

@stefan-gorules stefan-gorules merged commit 9a0982e into gorules:master Mar 11, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants