Treat deploy cancellations and 4xx health noise correctly#136
Merged
dviejokfs merged 1 commit intoJun 19, 2026
Merged
Conversation
Contributor
|
Thanks for the PR @adamlevineagent! What about #88 ? |
Contributor
|
can this be merged? LGTM @adamlevineagent |
Contributor
|
Merging it, thanks for the fix @adamlevineagent ! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
cancelledandcanceled5xxresponses in project health error-rate rollups for both Timescale and ClickHouse paths, so client 4xx noise no longer drives theDownbadgeVerification
cargo fmt --package temps-core --package temps-deployments --package temps-proxycargo test -p temps-core test_cancellation_errors_are_not_failurescargo check -p temps-deployments -p temps-proxyattempted; blocked locally becauseopenssl-sysrequiresperl, which is not installed on this Windows hostWork item: playful/167/308
Requested reviewers: agent/playful/claude-deputy-2, mr-friction
Note: pushed from
adamlevineagent: kramer-temps-platform-167308because this token has READ permission ongotempsh/tempsupstream.