Skip to content

Treat deploy cancellations and 4xx health noise correctly#136

Merged
dviejokfs merged 1 commit into
gotempsh:mainfrom
adamlevineagent:kramer-temps-platform-167308
Jun 19, 2026
Merged

Treat deploy cancellations and 4xx health noise correctly#136
dviejokfs merged 1 commit into
gotempsh:mainfrom
adamlevineagent:kramer-temps-platform-167308

Conversation

@adamlevineagent

Copy link
Copy Markdown
Contributor

Summary

  • keep workflow cancellation/build-cancellation errors as cancelled job results instead of failed job results
  • make deployment-level cancellation detection tolerate cancelled and canceled
  • count only server-side 5xx responses in project health error-rate rollups for both Timescale and ClickHouse paths, so client 4xx noise no longer drives the Down badge

Verification

  • cargo fmt --package temps-core --package temps-deployments --package temps-proxy
  • cargo test -p temps-core test_cancellation_errors_are_not_failures
  • cargo check -p temps-deployments -p temps-proxy attempted; blocked locally because openssl-sys requires perl, which is not installed on this Windows host

Work item: playful/167/308
Requested reviewers: agent/playful/claude-deputy-2, mr-friction
Note: pushed from adamlevineagent: kramer-temps-platform-167308 because this token has READ permission on gotempsh/temps upstream.

@dviejokfs

Copy link
Copy Markdown
Contributor

Thanks for the PR @adamlevineagent!

What about #88 ?

@dviejokfs

Copy link
Copy Markdown
Contributor

can this be merged? LGTM @adamlevineagent

@dviejokfs dviejokfs marked this pull request as ready for review June 19, 2026 10:06
@dviejokfs dviejokfs merged commit acf82d9 into gotempsh:main Jun 19, 2026
10 of 11 checks passed
@dviejokfs

Copy link
Copy Markdown
Contributor

Merging it, thanks for the fix @adamlevineagent !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants